remoev inheritance

Author: h-mayorquin

apps/probe-viewer/src/grouping/README.md

@@ -18,13 +18,10 @@ dependency. The config is `{ hierarchy }`, a tree of nodes. Each node has a
 `label` and either `children` (more nodes) or `probes` (model ids, in display
 order) at the leaves.
 
-`collapsible` is a per-node property that **propagates to descendants**: a node
-uses its own `collapsible` when set, otherwise it inherits the resolved value of
-its parent, and the top-level default is `true`. So only the exceptions need
-stating: the length bands set `collapsible: false` (a static, always-open
-divider) and that flows down to their probes, while everything else omits it and
-inherits the default. `true` is a foldable header with a caret; `false` is a
-static divider.
+`collapsible` is a per-node property that **defaults to `true`**, so only the
+exceptions need stating: the length bands set `collapsible: false`, while every
+other node omits it. `true` is a foldable header with a caret; `false` is a
+static, always-open divider.
 
 The walker (`groupEntries.ts`) attaches each manifest entry to the node listing
 its model, prunes empty branches, and collects anything not placed into a

apps/probe-viewer/src/grouping/groupEntries.ts

@@ -6,14 +6,10 @@ import type { GroupNode, HierarchyConfig, HierarchyNode } from "./types";
 // probe needs a home in the config.
 const UNGROUPED_LABEL = "Ungrouped";
 
-// Top-level default when a node does not set `collapsible` and has no parent.
-const ROOT_COLLAPSIBLE = true;
-
 // Resolves the explicit hierarchy against the given (already search-filtered)
 // entries: attaches each entry to the node that lists its model id, prunes
 // empty branches, and gathers anything unplaced into a trailing "Ungrouped"
-// group. `collapsible` is resolved per node, inheriting the parent's value when
-// the node does not set its own.
+// group. `collapsible` is per node and defaults to true.
 export function groupEntries(
   entries: ManifestEntry[],
   config: HierarchyConfig,
@@ -22,12 +18,12 @@ export function groupEntries(
   for (const entry of entries) byModel.set(entry.model, entry);
   const placed = new Set<string>();
 
-  const walk = (node: HierarchyNode, inherited: boolean): GroupNode | null => {
-    const collapsible = node.collapsible ?? inherited;
+  const walk = (node: HierarchyNode): GroupNode | null => {
+    const collapsible = node.collapsible ?? true;
 
     if (node.children) {
       const children = node.children
-        .map((child) => walk(child, collapsible))
+        .map((child) => walk(child))
         .filter((child): child is GroupNode => child !== null);
       if (children.length === 0) return null;
       const count = children.reduce((sum, child) => sum + child.count, 0);
@@ -47,7 +43,7 @@ export function groupEntries(
   };
 
   const groups = config.hierarchy
-    .map((node) => walk(node, ROOT_COLLAPSIBLE))
+    .map((node) => walk(node))
     .filter((group): group is GroupNode => group !== null);
 
   const leftovers = entries.filter((entry) => !placed.has(entry.model));

apps/probe-viewer/src/grouping/types.ts

@@ -5,16 +5,14 @@ import type { ManifestEntry } from "../types/probe";
 // model ids at the leaves. A manufacturer with no config renders as a flat list
 // (see ./index.ts).
 //
-// Collapsibility is a per-node property that propagates to descendants: a node
-// uses its own `collapsible` when set, otherwise it inherits the resolved value
-// of its parent, and the top-level default is `true`. So only the exceptions
-// need stating: the length bands set `collapsible: false`, which flows down to
-// their probes, while everything else inherits the default and stays foldable.
+// Collapsibility is per node and defaults to `true`, so only the exceptions
+// need stating: the length bands set `collapsible: false` to render as static
+// dividers, and every other node omits it and stays a foldable header.
 
 export interface HierarchyNode {
   label: string;
-  // true => a collapsible group header; false => a static, always-open divider.
-  // Omitted => inherit the parent's resolved value (root default: true).
+  // true (default) => a collapsible group header; false => a static, always-open
+  // divider.
   collapsible?: boolean;
   children?: HierarchyNode[];
   probes?: string[]; // model ids, in display order