Merge pull request #215 from yarikoptic/enh-codespell

chore: add codespell support (config, workflow to detect/not fix) and make it fix some typos

Author: alejoe91

.github/workflows/codespell.yml

@@ -0,0 +1,27 @@
+# Codespell configuration is within pyproject.toml
+---
+name: Codespell
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+permissions:
+  contents: read
+
+jobs:
+  codespell:
+    name: Check for spelling errors
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Annotate locations with typos
+        uses: codespell-project/codespell-problem-matcher@v1
+      - name: Codespell
+        uses: codespell-project/actions-codespell@v2
+        with:
+          ignore_words_list: sortings,trough

TODO.md

@@ -12,7 +12,7 @@ Controls
 ~~~~~~~~
 - **left click** : select single unit
 - **ctrl + left click** : add unit to selection
-- **mouse drag from within circle** : change channel visibilty and unit visibility on other views
+- **mouse drag from within circle** : change channel visibility and unit visibility on other views
 - **mouse drag from "diamond"** : change channel / unit radii size
 
 Screenshots

docs/source/views.rst

@@ -64,3 +64,10 @@ docs = [
     "sphinx>=5.0",
     "sphinx_rtd_theme",
 ]
+
+[tool.codespell]
+# Ref: https://github.com/codespell-project/codespell#using-a-config-file
+skip = '.git*,pyproject.toml'
+check-hidden = true
+# ignore-regex = ''
+ignore-words-list = 'nd,gaus'

pyproject.toml

@@ -1,7 +1,7 @@
 """
 Some design notes:
   * controller is a layer between spikeinterface objects and every view
-  * every view can notify some signals to other view that are centralized bu the controller
+  * every view can notify some signals to other view that are centralized by the controller
   * views have settings
   * views have 2 implementations : qt (legacy) and panel (for the web)
     They need to implement the make_layout and the refresh for each backends (qt, panel).

spikeinterface_gui/__init__.py

@@ -207,7 +207,7 @@ def __init__(self, controller, layout_dict=None, user_settings=None):
         self.make_views(user_settings)
         self.create_main_layout()
 
-        # refresh all views wihtout notiying
+        # refresh all views without notiying
         self.controller.signal_handler.deactivate()
         self.controller.signal_handler.activate()
 
@@ -286,7 +286,7 @@ def create_main_layout(self):
         layout_zone = {}
         self.all_tabs = []
         for zone, view_names in preset.items():
-            # keep only instanciated views
+            # keep only instantiated views
             view_names = [view_name for view_name in view_names if view_name in self.view_layouts.keys()]
 
             if len(view_names) == 0:

spikeinterface_gui/backend_panel.py

@@ -48,7 +48,7 @@ def notify_unit_color_changed(self):
         self.unit_color_changed.emit()
 
 
-# Used by controler to handle/callback signals
+# Used by controller to handle/callback signals
 class SignalHandler(QT.QObject):
     def __init__(self, controller, parent=None):
         QT.QObject.__init__(self, parent=parent)
@@ -171,13 +171,13 @@ def __init__(self, controller, parent=None, layout_dict=None, user_settings=None
         self.make_views(user_settings)
         self.create_main_layout()
 
-        # refresh all views wihtout notiying
+        # refresh all views without notiying
         self.controller.signal_handler.deactivate()
         for view in self.views.values():
             # refresh do not work because view are not yet visible at init
             view._refresh()
         self.controller.signal_handler.activate()
-        # TODO sam : all veiws are always refreshed at the moment so this is useless.
+        # TODO sam : all views are always refreshed at the moment so this is useless.
         # uncommen this when ViewBase.is_view_visible() work correctly
         # for view_name, dock in self.docks.items():
         #     dock.visibilityChanged.connect(self.views[view_name].refresh)

spikeinterface_gui/backend_qt.py

@@ -84,7 +84,7 @@ def __init__(
             self.main_settings.update(user_main_settings)
 
         self.num_channels = self.analyzer.get_num_channels()
-        # this now private and shoudl be acess using function
+        # this now private and should be access using function
         self._visible_unit_ids = [self.unit_ids[0]]
 
         # sparsity
@@ -574,7 +574,7 @@ def get_visible_unit_ids(self):
         return self._visible_unit_ids
 
     def get_visible_unit_indices(self):
-        """Get list of indicies of visible units"""
+        """Get list of indices of visible units"""
         unit_ids = list(self.unit_ids)
         visible_unit_indices = [unit_ids.index(u) for u in self._visible_unit_ids]
         return visible_unit_indices

spikeinterface_gui/controller.py

@@ -39,7 +39,7 @@ def __init__(self, controller=None, parent=None, backend="qt"):
         self.selected_comp = np.ones((ndim), dtype='bool')
         self.projection = self.get_one_random_projection()
 
-        #estimate limts
+        #estimate limits
         data = self.data
         if data.shape[0] > 1000:
             inds = np.random.choice(data.shape[0], 1000, replace=False)
@@ -281,7 +281,7 @@ def _qt_refresh(self, update_components=True, update_colors=True):
             self.update_selected_components()
 
         #ndscatter
-        # TODO sam: I have the feeling taht it is a bit slow
+        # TODO sam: I have the feeling that it is a bit slow
         self.scatter.clear()
 
         # scatter_x, scatter_y, spike_indices, selected_scatter_x, selected_scatter_y = self.get_plotting_data(concatenated=True)
@@ -298,7 +298,7 @@ def _qt_refresh(self, update_components=True, update_colors=True):
         self.scatter_select.setData(selected_scatter_x, selected_scatter_y)
 
 
-        # TODO sam : kepp the old implementation in mind
+        # TODO sam : keep the old implementation in mind
         # for unit_index, unit_id in enumerate(self.controller.unit_ids):
         #     if not self.controller.get_unit_visibility(unit_id):
         #         continue
@@ -368,7 +368,7 @@ def _qt_on_lasso_finished(self, points, shift_held=False):
         vertices = np.array(points)
         self._lasso_vertices.append(vertices)
 
-        # inside lasso and visibles
+        # inside lasso and visible
         ind_visibles,   = np.nonzero(np.isin(self.random_spikes_indices, self.controller.get_indices_spike_visible()))
         projected = self.apply_dot(self.data[ind_visibles, :])
         inside = inside_poly(projected, vertices)
@@ -569,7 +569,7 @@ def _on_panel_selection_geometry(self, event):
             else:
                 self._lasso_vertices = [polygon]
 
-            # inside lasso and visibles
+            # inside lasso and visible
             ind_visibles, = np.nonzero(np.isin(self.random_spikes_indices, self.controller.get_indices_spike_visible()))
             inds = self.random_spikes_indices[ind_visibles[selected]]
             self.controller.set_indices_spike_selected(inds)

spikeinterface_gui/ndscatterview.py

@@ -761,6 +761,6 @@ def circle_from_roi(roi):
 ### Controls
 - **left click** : select single unit
 - **ctrl + left click** : add unit to selection
-- **mouse drag from within circle** : change channel visibilty and unit visibility on other views
+- **mouse drag from within circle** : change channel visibility and unit visibility on other views
 - **mouse drag from "diamond"** : change channel / unit radii size
 """