Skip to content

Commit e1b5e7a

Browse files
authored
Fix int32 error once and for all (#263)
1 parent 50ea250 commit e1b5e7a

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

spikeinterface_gui/tracemapview.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,8 @@ def _qt_seek(self, t):
131131
sr = self.controller.sampling_frequency
132132

133133
self.scroll_time.valueChanged.disconnect(self._qt_on_scroll_time)
134-
value = self.controller.time_to_sample_index(t)
134+
sample = self.controller.time_to_sample_index(t)
135+
value = int(sample / self.scroll_step)
135136
self.scroll_time.setValue(value)
136137
self.scroll_time.setPageStep(int(sr*xsize))
137138
self.scroll_time.valueChanged.connect(self._qt_on_scroll_time)

spikeinterface_gui/traceview.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313
# * segment change
1414
# *
1515

16+
INT32_MAX = 2147483647 # 2**31 - 1
17+
18+
1619
class MixinViewTrace:
1720

1821
MAX_RETRIEVE_TIME_FOR_BUSY_CURSOR = 0.5 # seconds
@@ -214,7 +217,7 @@ def _qt_initialize_plot(self):
214217
def _qt_update_scroll_step(self):
215218
segment_index = self.controller.get_time()[1]
216219
length = self.controller.get_num_samples(segment_index)
217-
num_scrollbar_steps = max(2**16, length)
220+
num_scrollbar_steps = min(INT32_MAX, length)
218221
self.scroll_step = length / num_scrollbar_steps
219222

220223
t_start, t_stop = self.controller.get_t_start_t_stop()

0 commit comments

Comments
 (0)