Skip to content

Commit 115c828

Browse files
authored
Merge pull request #3892 from alejoe91/benchmarks-not-load-extensions
Skip loading extensions when instantiating benchmarks
2 parents 87f9b91 + e70ecac commit 115c828

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

src/spikeinterface/benchmark/benchmark_base.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -176,18 +176,12 @@ def scan_folder(self):
176176
self.levels = self.info["levels"]
177177

178178
for key, folder in self.analyzers_path.items():
179-
analyzer = load_sorting_analyzer(folder)
179+
analyzer = load_sorting_analyzer(folder, load_extensions=False)
180180
self.analyzers[key] = analyzer
181181
# the sorting is in memory here we take the saved one because comparisons need to pickle it later
182182
sorting = load(analyzer.folder / "sorting")
183183
self.datasets[key] = analyzer.recording, sorting
184184

185-
# for rec_file in (self.folder / "datasets" / "recordings").glob("*.pickle"):
186-
# key = rec_file.stem
187-
# rec = load(rec_file)
188-
# gt_sorting = load(self.folder / f"datasets" / "gt_sortings" / key)
189-
# self.datasets[key] = (rec, gt_sorting)
190-
191185
with open(self.folder / "cases.pickle", "rb") as f:
192186
self.cases = pickle.load(f)
193187

src/spikeinterface/benchmark/benchmark_plot_tools.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,9 @@ def plot_performances_vs_snr(
494494

495495
colors = study.get_colors(levels_to_group_by=levels_to_keep)
496496

497-
assert all([key in colors for key in case_keys]), f"colors must have a color for each case key: {case_keys}"
497+
assert all(
498+
[key in colors for key in case_group_keys]
499+
), f"colors must have a color for each case key: {case_group_keys}"
498500

499501
for key, key_list in case_group_keys.items():
500502
color = colors[key]

0 commit comments

Comments
 (0)