Skip to content

Commit 150d2d7

Browse files
committed
add todo for analyzer extension safeguards
1 parent 8d3e274 commit 150d2d7

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

src/spikeinterface/core/sortinganalyzer.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1593,6 +1593,7 @@ def get_num_units(self) -> int:
15931593
return self.sorting.get_num_units()
15941594

15951595
## extensions zone
1596+
# TODO (tayheau): add a safeguard e.g. memory error or SIGINT
15961597
def compute(self, input, save=True, extension_params=None, verbose=False, **kwargs) -> "AnalyzerExtension | None":
15971598
"""
15981599
Compute one extension or several extensiosn.
@@ -2663,6 +2664,7 @@ def save(self):
26632664

26642665
zarr.consolidate_metadata(self.sorting_analyzer._get_zarr_root().store)
26652666

2667+
# TODO (tayheau): add safeguard in writing case
26662668
def _save_data(self):
26672669
if self.format == "memory":
26682670
return

0 commit comments

Comments
 (0)