Skip to content

Commit 201c48a

Browse files
Refactor standard units check
1 parent 508de1e commit 201c48a

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

src/spikeinterface/extractors/neoextractors/neobaseextractor.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -260,16 +260,14 @@ def __init__(
260260
units = signal_channels["units"]
261261

262262
# mark that units are V, mV or uV
263+
standard_units_and_additional_gains = {"V": 1e6, "Volt": 1e6, "mV": 1e3, "uV": 1.0}
263264
self.has_non_standard_units = False
264-
if not np.all(np.isin(units, ["V", "Volt", "mV", "uV"])):
265+
if not np.all(np.isin(units, list(standard_units_and_additional_gains.keys()))):
265266
self.has_non_standard_units = True
266267

267268
additional_gain = np.ones(units.size, dtype="float")
268-
additional_gain[units == "V"] = 1e6
269-
additional_gain[units == "Volt"] = 1e6
270-
additional_gain[units == "mV"] = 1e3
271-
additional_gain[units == "uV"] = 1.0
272-
additional_gain = additional_gain
269+
for key, value in standard_units_and_additional_gains.items():
270+
additional_gain[units == key] = value
273271

274272
final_gains = gains * additional_gain
275273
final_offsets = offsets * additional_gain

0 commit comments

Comments
 (0)