Skip to content

Commit 2d74067

Browse files
committed
Fix set_properties_after_merging when property is boolean.
This was introducing bugs in auto_merge
1 parent 705d194 commit 2d74067

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

src/spikeinterface/core/sorting_tools.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,8 +361,14 @@ def set_properties_after_merging(
361361
keep_pre_inds = sorting_pre_merge.ids_to_indices(kept_unit_ids)
362362
keep_post_inds = sorting_post_merge.ids_to_indices(kept_unit_ids)
363363

364+
default_missing_values = BaseExtractor.default_missing_property_values
365+
364366
for key in prop_keys:
365367
parent_values = sorting_pre_merge.get_property(key)
368+
if parent_values.dtype.kind not in default_missing_values:
369+
# if the property is boolean or integer there is no missing values so we skip
370+
# for instance reccussive "is_merged" will not be propagated
371+
continue
366372

367373
# propagate keep values
368374
shape = (len(sorting_post_merge.unit_ids),) + parent_values.shape[1:]
@@ -377,7 +383,7 @@ def set_properties_after_merging(
377383
# and new values only if they are all similar
378384
new_values[new_index] = merge_values[0]
379385
else:
380-
default_missing_values = BaseExtractor.default_missing_property_values
386+
381387
new_values[new_index] = default_missing_values[parent_values.dtype.kind]
382388
sorting_post_merge.set_property(key, new_values)
383389

0 commit comments

Comments
 (0)