Skip to content

Commit 77d9eaf

Browse files
authored
Merge pull request #3309 from rkim48/sortingview-curation-fix
Fix sortingview curation no merge case
2 parents be0fd8a + b6316b5 commit 77d9eaf

3 files changed

Lines changed: 20 additions & 3 deletions

File tree

src/spikeinterface/curation/curation_format.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,13 +92,17 @@ def convert_from_sortingview_curation_format_v0(sortingview_dict, destination_fo
9292
"""
9393

9494
assert destination_format == "1"
95-
95+
if "mergeGroups" not in sortingview_dict.keys():
96+
sortingview_dict["mergeGroups"] = []
9697
merge_groups = sortingview_dict["mergeGroups"]
9798
merged_units = sum(merge_groups, [])
98-
if len(merged_units) > 0:
99-
unit_id_type = int if isinstance(merged_units[0], int) else str
99+
100+
first_unit_id = next(iter(sortingview_dict["labelsByUnit"].keys()))
101+
if str.isdigit(first_unit_id):
102+
unit_id_type = int
100103
else:
101104
unit_id_type = str
105+
102106
all_units = []
103107
all_labels = []
104108
manual_labels = []
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"labelsByUnit":{"2":["mua"],"3":["mua"],"4":["mua"],"5":["accept"],"6":["accept"],"7":["accept"],"8":["artifact"],"9":["artifact"]}}

src/spikeinterface/curation/tests/test_sortingview_curation.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,11 +243,23 @@ def test_label_inheritance_str():
243243
assert np.all(sorting_include_accept.get_property("accept"))
244244

245245

246+
def test_json_no_merge_curation():
247+
"""
248+
Test curation with no merges using a JSON file.
249+
"""
250+
sorting = generate_sorting(num_units=10)
251+
252+
json_file = parent_folder / "sv-sorting-curation-no-merge.json"
253+
sorting_curated = apply_sortingview_curation(sorting, uri_or_json=json_file)
254+
255+
246256
if __name__ == "__main__":
247257
# generate_sortingview_curation_dataset()
248258
# test_sha1_curation()
259+
249260
test_gh_curation()
250261
test_json_curation()
251262
test_false_positive_curation()
252263
test_label_inheritance_int()
253264
test_label_inheritance_str()
265+
test_json_no_merge_curation()

0 commit comments

Comments
 (0)