Skip to content

Commit 7882450

Browse files
Fix failing tests (#4560)
Co-authored-by: Chris Halcrow <57948917+chrishalcrow@users.noreply.github.com>
1 parent 36ad576 commit 7882450

6 files changed

Lines changed: 99 additions & 12 deletions

File tree

doc/releases/0.104.1.rst

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
.. _release0.104.1:
2+
3+
SpikeInterface 0.104.1 release notes
4+
------------------------------------
5+
6+
April 7th 2025
7+
8+
Minor release with bug fixes
9+
10+
11+
extractors:
12+
13+
* Align CompressedBinaryIBLExtractor with updated get_neuropixels_sample_shifts (#4477)
14+
15+
16+
postprocessing:
17+
18+
* Make get_data for valid unit periods use unit ids, not indices ( #4468)
19+
* Remove tmp_data_to_save when loading old analyzers (#4480)
20+
* Handle peak_sign for quality metrics in _handle_backward_compatibility_on_load (#4481)
21+
22+
23+
Contributors:
24+
25+
* @chrishalcrow
26+
* @hayleybounds

doc/releases/0.104.2.rst

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
.. _release0.104.2:
2+
3+
SpikeInterface 0.104.2 release notes
4+
------------------------------------
5+
6+
April 20th 2025
7+
8+
Minor release with bug fixes
9+
10+
core:
11+
12+
* Fix ``WaveformExtractor`` backwards compatibility: run backwards compatibility migration before validating metrics (#4509)
13+
* Make version mismatch warning informative and actionable (#4505)
14+
15+
extractors:
16+
17+
* Open Ephys: find root folder to correctly look for timestamps (#4500)
18+
19+
20+
Contributors:
21+
22+
* @alejoe91
23+
* @h-mayorquin
24+
* @galenlynch

doc/releases/0.104.3.rst

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
.. _release0.104.3:
2+
3+
SpikeInterface 0.104.3 release notes
4+
------------------------------------
5+
6+
April 22th 2025
7+
8+
Minor release with bug fixes
9+
10+
preprocessing:
11+
12+
* Fix filter kwargs (#4543)
13+
14+
widgets:
15+
16+
* Fix sortingview "backend" in plot_sorting_summary (#4554)
17+
18+
19+
Contributors:
20+
21+
* @alejoe91

doc/whatisnew.rst

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ Release notes
88
.. toctree::
99
:maxdepth: 1
1010

11+
releases/0.104.3.rst
12+
releases/0.104.2.rst
13+
releases/0.104.1.rst
1114
releases/0.104.0.rst
1215
releases/0.103.2.rst
1316
releases/0.103.1.rst
@@ -52,6 +55,21 @@ Release notes
5255
releases/0.9.9.rst
5356
releases/0.9.1.rst
5457

58+
Version 0.104.3
59+
===============
60+
61+
* Minor release with bug fixes
62+
63+
Version 0.104.2
64+
===============
65+
66+
* Minor release with bug fixes
67+
68+
Version 0.104.1
69+
===============
70+
71+
* Minor release with bug fixes
72+
5573
Version 0.104.0
5674
===============
5775

pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,10 @@ test-curation = [{include-group = "test-common"}]
268268
test-widgets = [
269269
{include-group = "test-common"},
270270
"sortingview>=0.12.0",
271+
"numba>=0.59", # For motion widget
272+
"scikit-learn",
273+
"pyvips",
274+
"networkx",
271275
]
272276

273277
test-exporters = [{include-group = "test-common"}]

src/spikeinterface/extractors/neoextractors/spikeglx.py

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class SpikeGLXRecordingExtractor(NeoBaseRecordingExtractor):
2323
----------
2424
folder_path : str
2525
The folder path to load the recordings from.
26-
load_sync_channel : bool default: False
27-
Whether or not to load the last channel in the stream, which is typically used for synchronization.
28-
If True, then the probe is not loaded.
2926
stream_id : str or None, default: None
3027
If there are several streams, specify the stream id you want to load.
3128
For example, "imec0.ap", "nidq", or "imec0.lf".
@@ -40,24 +37,21 @@ class SpikeGLXRecordingExtractor(NeoBaseRecordingExtractor):
4037
Examples
4138
--------
4239
>>> from spikeinterface.extractors import read_spikeglx
43-
>>> recording = read_spikeglx(folder_path=r'path_to_folder_with_data', load_sync_channel=False)
44-
# we can load the sync channel, but then the probe is not loaded
45-
>>> recording = read_spikeglx(folder_path=r'pat_to_folder_with_data', load_sync_channel=True)
40+
>>> recording = read_spikeglx(folder_path=r'path_to_folder_with_data')
4641
"""
4742

4843
NeoRawIOClass = "SpikeGLXRawIO"
4944

5045
def __init__(
5146
self,
5247
folder_path,
53-
load_sync_channel=False,
5448
stream_id=None,
5549
stream_name=None,
5650
all_annotations: bool = False,
5751
use_names_as_ids: bool = False,
5852
):
5953

60-
neo_kwargs = self.map_to_neo_kwargs(folder_path, load_sync_channel=load_sync_channel)
54+
neo_kwargs = self.map_to_neo_kwargs(folder_path)
6155
NeoBaseRecordingExtractor.__init__(
6256
self,
6357
stream_id=stream_id,
@@ -67,7 +61,7 @@ def __init__(
6761
**neo_kwargs,
6862
)
6963

70-
self._kwargs.update(dict(folder_path=str(Path(folder_path).absolute()), load_sync_channel=load_sync_channel))
64+
self._kwargs.update(dict(folder_path=str(Path(folder_path).absolute())))
7165

7266
stream_is_nidq = "nidq" in self.stream_id
7367
stream_is_one_box = "obx" in self.stream_id
@@ -83,7 +77,7 @@ def __init__(
8377

8478
ap_meta_filename = meta_filename.replace(".lf", ".ap") if "lf" in self.stream_id else meta_filename
8579
ap_meta_file_exists = Path(ap_meta_filename).exists()
86-
add_probe_properties = ap_meta_file_exists and not load_sync_channel
80+
add_probe_properties = ap_meta_file_exists
8781

8882
if add_probe_properties:
8983
probe = probeinterface.read_spikeglx(ap_meta_filename)
@@ -105,8 +99,8 @@ def __init__(
10599
warnings.warn(warning_message, UserWarning, stacklevel=2)
106100

107101
@classmethod
108-
def map_to_neo_kwargs(cls, folder_path, load_sync_channel=False):
109-
neo_kwargs = {"dirname": str(folder_path), "load_sync_channel": load_sync_channel}
102+
def map_to_neo_kwargs(cls, folder_path):
103+
neo_kwargs = {"dirname": str(folder_path)}
110104
return neo_kwargs
111105

112106

0 commit comments

Comments
 (0)