Skip to content

Commit 7b128f9

Browse files
authored
Merge pull request #2161 from alejoe91/fix-maxwell-tests
Fix maxwell tests by setting `HDF5_PLUGIN_PATH` env in action
2 parents 3e04bd3 + 8f6f296 commit 7b128f9

3 files changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/full-test-with-codecov.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ jobs:
5252
- name: Shows installed packages by pip, git-annex and cached testing files
5353
uses: ./.github/actions/show-test-environment
5454
- name: run tests
55+
env:
56+
HDF5_PLUGIN_PATH: ${{ github.workspace }}/hdf5_plugin_path_maxwell
5557
run: |
5658
source ${{ github.workspace }}/test_env/bin/activate
5759
pytest -m "not sorters_external" --cov=./ --cov-report xml:./coverage.xml -vv -ra --durations=0 | tee report_full.txt; test ${PIPESTATUS[0]} -eq 0 || exit 1

.github/workflows/full-test.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,8 @@ jobs:
132132
- name: Test core
133133
run: ./.github/run_tests.sh core
134134
- name: Test extractors
135+
env:
136+
HDF5_PLUGIN_PATH: ${{ github.workspace }}/hdf5_plugin_path_maxwell
135137
if: ${{ steps.modules-changed.outputs.EXTRACTORS_CHANGED == 'true' || steps.modules-changed.outputs.CORE_CHANGED == 'true' }}
136138
run: ./.github/run_tests.sh "extractors and not streaming_extractors"
137139
- name: Test preprocessing

src/spikeinterface/extractors/tests/test_neoextractors.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,6 @@ class CedRecordingTest(RecordingCommonTestSuite, unittest.TestCase):
278278
]
279279

280280

281-
@pytest.mark.skipif(ON_GITHUB, reason="Maxwell plugin not installed on GitHub")
282281
class MaxwellRecordingTest(RecordingCommonTestSuite, unittest.TestCase):
283282
ExtractorClass = MaxwellRecordingExtractor
284283
downloads = ["maxwell"]

0 commit comments

Comments
 (0)