Skip to content

Commit 8141538

Browse files
authored
Merge pull request #3692 from alejoe91/add-missing-parents
Add `_parent` to `select_segment` classes
2 parents e818f30 + e0045af commit 8141538

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/spikeinterface/core/channelslice.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,10 @@ def __init__(self, parent_recording, channel_ids=None, renamed_channel_ids=None)
2525
np.unique(renamed_channel_ids)
2626
), "renamed_channel_ids must be unique!"
2727

28-
self._parent_recording = parent_recording
2928
self._channel_ids = np.asarray(channel_ids)
3029
self._renamed_channel_ids = np.asarray(renamed_channel_ids)
3130

32-
parents_chan_ids = self._parent_recording.get_channel_ids()
31+
parents_chan_ids = parent_recording.get_channel_ids()
3332

3433
# some checks
3534
assert all(
@@ -54,7 +53,7 @@ def __init__(self, parent_recording, channel_ids=None, renamed_channel_ids=None)
5453
self._parent_channel_indices = parent_recording.ids_to_indices(self._channel_ids)
5554

5655
# link recording segment
57-
for parent_segment in self._parent_recording._recording_segments:
56+
for parent_segment in parent_recording._recording_segments:
5857
sub_segment = ChannelSliceRecordingSegment(parent_segment, self._parent_channel_indices)
5958
self.add_recording_segment(sub_segment)
6059

src/spikeinterface/core/segmentutils.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,7 @@ def __init__(self, recording: BaseRecording, segment_indices: int | list[int]):
243243
for segment_index in segment_indices:
244244
rec_seg = recording._recording_segments[segment_index]
245245
self.add_recording_segment(rec_seg)
246+
self._parent = recording
246247

247248
self._kwargs = {"recording": recording, "segment_indices": segment_indices}
248249

@@ -564,6 +565,7 @@ def __init__(self, parent_sorting: BaseSorting, recording_or_recording_list=None
564565
)
565566
sliced_segment = sliced_parent_sorting._sorting_segments[0]
566567
self.add_sorting_segment(sliced_segment)
568+
self._parent = parent_sorting
567569

568570
self._kwargs = {"parent_sorting": parent_sorting, "recording_or_recording_list": recording_list}
569571

src/spikeinterface/preprocessing/basepreprocessor.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ class BasePreprocessor(BaseRecording):
99
def __init__(self, recording, sampling_frequency=None, channel_ids=None, dtype=None):
1010
assert isinstance(recording, BaseRecording), "'recording' must be a RecordingExtractor"
1111

12-
self._parent_recording = recording
1312
if sampling_frequency is None:
1413
sampling_frequency = recording.get_sampling_frequency()
1514
if channel_ids is None:

0 commit comments

Comments
 (0)