Skip to content

Commit 8a1870c

Browse files
authored
Merge pull request #3417 from alejoe91/fixes-convert-dtypes
Fix metrics widgets for convert_dtypes
2 parents 83bad08 + 9834996 commit 8a1870c

3 files changed

Lines changed: 8 additions & 5 deletions

File tree

src/spikeinterface/widgets/metrics.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,9 @@ def plot_sortingview(self, data_plot, **backend_kwargs):
235235
values = check_json(metrics.loc[unit_id].to_dict())
236236
values_skip_nans = {}
237237
for k, v in values.items():
238+
# convert_dypes returns NaN as None or np.nan (for float)
239+
if v is None:
240+
continue
238241
if np.isnan(v):
239242
continue
240243
values_skip_nans[k] = v

src/spikeinterface/widgets/tests/test_widgets.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def setUpClass(cls):
7373
spike_amplitudes=dict(),
7474
unit_locations=dict(),
7575
spike_locations=dict(),
76-
quality_metrics=dict(metric_names=["snr", "isi_violation", "num_spikes"]),
76+
quality_metrics=dict(metric_names=["snr", "isi_violation", "num_spikes", "amplitude_cutoff"]),
7777
template_metrics=dict(),
7878
correlograms=dict(),
7979
template_similarity=dict(),

src/spikeinterface/widgets/utils_sortingview.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,9 @@ def generate_unit_table_view(
106106
if prop_name in sorting_props:
107107
property_values = sorting.get_property(prop_name)
108108
elif prop_name in qm_props:
109-
property_values = qm_data[prop_name].values
109+
property_values = qm_data[prop_name].to_numpy()
110110
elif prop_name in tm_props:
111-
property_values = tm_data[prop_name].values
111+
property_values = tm_data[prop_name].to_numpy()
112112
else:
113113
warn(f"Property '{prop_name}' not found in sorting, quality_metrics, or template_metrics")
114114
continue
@@ -137,9 +137,9 @@ def generate_unit_table_view(
137137
if prop_name in sorting_props:
138138
property_values = sorting.get_property(prop_name)
139139
elif prop_name in qm_props:
140-
property_values = qm_data[prop_name].values
140+
property_values = qm_data[prop_name].to_numpy()
141141
elif prop_name in tm_props:
142-
property_values = tm_data[prop_name].values
142+
property_values = tm_data[prop_name].to_numpy()
143143

144144
# Check for NaN values and round floats
145145
val0 = np.array(property_values[0])

0 commit comments

Comments
 (0)