File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -208,7 +208,7 @@ def get_annotation_keys(self) -> List:
208208 def set_property (
209209 self ,
210210 key ,
211- values : list | np .ndarray | tuple | None ,
211+ values : list | np .ndarray | tuple ,
212212 ids : list | np .ndarray | tuple | None = None ,
213213 missing_value : Any = None ,
214214 ) -> None :
@@ -236,12 +236,6 @@ def set_property(
236236 The missing_value has to be specified for types int and unsigned int.
237237 """
238238
239- # This deletes the values but we have `delete_property` maybe we should eliminate this?
240- if values is None :
241- if key in self ._properties :
242- self ._properties .pop (key )
243- return
244-
245239 size = self ._main_ids .size
246240 values = np .asarray (values )
247241 dtype = values .dtype
@@ -267,7 +261,7 @@ def set_property(
267261 if dtype_kind not in self .default_missing_property_values .keys ():
268262 raise ValueError (
269263 f"Can't infer a natural missing value for dtype { dtype_kind } . "
270- "Please provide it with the missing_value argument"
264+ "Please provide it with the ` missing_value` argument"
271265 )
272266 else :
273267 missing_value = self .default_missing_property_values [dtype_kind ]
You can’t perform that action at this time.
0 commit comments