Skip to content

Commit 9c338dd

Browse files
committed
Fix KS parameters in tests
1 parent e26e143 commit 9c338dd

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

.github/scripts/test_kilosort4_ci.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,9 @@
9090
("ccg_threshold", 1e12),
9191
("acg_threshold", 1e12),
9292
("cluster_downsampling", 2),
93-
("duplicate_spike_ms", 0.3),
9493
("drift_smoothing", [250, 250, 250]),
95-
("save_preprocessed_copy", False),
96-
("shift", 0),
97-
("scale", 1),
94+
# Not tested beacuse with ground truth data it doesn't change the results
95+
# ("duplicate_spike_ms", 0.3),
9896
]
9997

10098

@@ -210,6 +208,8 @@ def test_default_settings_all_represented(self):
210208
on the KS side.
211209
"""
212210
tested_keys = [entry[0] for entry in PARAMS_TO_TEST]
211+
additional_non_tested_keys = ["shift", "scale", "save_preprocessed_copy", "duplicate_spike_ms"]
212+
tested_keys += additional_non_tested_keys
213213

214214
for param_key in DEFAULT_SETTINGS:
215215
if param_key not in ["n_chan_bin", "fs", "tmin", "tmax"]:
@@ -407,6 +407,11 @@ def test_kilosort4_no_correction(self, recording_and_paths, tmp_path):
407407
assert np.array_equal(results["ks"]["st"], results["si"]["st"])
408408
assert np.array_equal(results["ks"]["clus"], results["si"]["clus"])
409409

410+
411+
def test_kilosort4_use_binary_file(self, recording_and_paths, tmp_path):
412+
# TODO
413+
pass
414+
410415
@pytest.mark.parametrize(
411416
"param_to_test",
412417
[

0 commit comments

Comments
 (0)