Merge pull request #3318 from alejoe91/lazy-load-zarr-times

Lazy loading of zarr timestamps

Author: alejoe91

src/spikeinterface/core/baserecording.py

@@ -422,7 +422,7 @@ def get_time_info(self, segment_index=None) -> dict:
 
         return time_kwargs
 
-    def get_times(self, segment_index=None):
+    def get_times(self, segment_index=None) -> np.ndarray:
         """Get time vector for a recording segment.
 
         If the segment has a time_vector, then it is returned. Otherwise
@@ -809,12 +809,10 @@ def __init__(self, sampling_frequency=None, t_start=None, time_vector=None):
 
         BaseSegment.__init__(self)
 
-    def get_times(self):
+    def get_times(self) -> np.ndarray:
         if self.time_vector is not None:
-            if isinstance(self.time_vector, np.ndarray):
-                return self.time_vector
-            else:
-                return np.array(self.time_vector)
+            self.time_vector = np.asarray(self.time_vector)
+            return self.time_vector
         else:
             time_vector = np.arange(self.get_num_samples(), dtype="float64")
             time_vector /= self.sampling_frequency

src/spikeinterface/core/zarrextractors.py

@@ -66,7 +66,7 @@ def __init__(self, folder_path: Path | str, storage_options: dict | None = None)
             time_kwargs = {}
             time_vector = self._root.get(f"times_seg{segment_index}", None)
             if time_vector is not None:
-                time_kwargs["time_vector"] = time_vector[:]
+                time_kwargs["time_vector"] = time_vector
             else:
                 if t_starts is None:
                     t_start = None