make sure only valid keys are used in the threshold

Author: ecobost

src/spikeinterface/curation/tests/test_threshold_metrics_curation.py

@@ -219,3 +219,12 @@ def test_threshold_metrics_label_units_missing_metric_raises():
     thresholds = {"does_not_exist": {"greater": 0.0}}
     with pytest.raises(ValueError, match="specified in thresholds are not present"):
         threshold_metrics_label_units(metrics, thresholds)
+
+
+def test_threshold_metrics_label_units_invalid_threshold_keys_raises():
+    import pandas as pd
+
+    metrics = pd.DataFrame({"m1": [1.0]}, index=[0])
+    thresholds = {"m1": {"greater": 0.0, "invalid_key": 1.0}}
+    with pytest.raises(ValueError, match="contains invalid keys"):
+        threshold_metrics_label_units(metrics, thresholds)

src/spikeinterface/curation/threshold_metrics_curation.py

@@ -75,6 +75,14 @@ def threshold_metrics_label_units(
             f"Available metrics are: {metrics.columns.tolist()}"
         )
 
+    # Check that threshold dictionaries contain only valid keys
+    valid_keys = {"greater", "less", "abs"}
+    for metric_name, threshold in thresholds_dict.items():
+        if not set(threshold).issubset(valid_keys):
+            raise ValueError(
+                f"Threshold for metric '{metric_name}' contains invalid keys {set(threshold) - valid_keys}."
+            )
+
     if operator not in ("and", "or"):
         raise ValueError("operator must be 'and' or 'or'")
 

src/spikeinterface/widgets/bombcell_curation.py

@@ -30,7 +30,7 @@ class BombcellUpsetPlotWidget(BaseWidget):
         "non_soma", "non_soma_good", "non_soma_mua".
     thresholds : dict, optional
         Threshold dictionary with structure "noise", "mua", "non-somatic" as sections. Each section contains
-        metric names keys with "greater" and "less" thresholds. 
+        metric names keys with "greater" and "less" thresholds.
         If None, uses default thresholds.
     unit_labels_to_plot : list of str, optional
         List of unit labels to include in the plot. If None, defaults to all labels in thresholds.