noise: forgot that get_chunk_with_margin() -> tuple. also assert length is correct.

Author: cwindolf

src/spikeinterface/generation/noise_tools.py

@@ -220,7 +220,12 @@ def get_traces(
     ):
         from scipy.signal import convolve
 
-        traces = get_chunk_with_margin(
+        if start_frame is None:
+            start_frame = 0
+        if end_frame is None:
+            end_frame = self.get_num_samples()
+
+        traces, *_ = get_chunk_with_margin(
             self.parent_recording_segment,
             start_frame=start_frame,
             end_frame=end_frame,
@@ -231,6 +236,7 @@ def get_traces(
         # need to use "direct", or else output differs numerically when start_frame, end_frame change
         # that's because the FFT method would FFT the traces, and there would be slight numerical differences
         traces = convolve(traces.T, self.kernel[None], mode="valid", method="direct").T
+        assert traces.shape[0] == end_frame - start_frame
         return traces