Merge pull request #3972 from zm711/import-cleanup-again

Cleanup unused import across codebase

Author: samuelgarcia

src/spikeinterface/core/analyzer_extension_core.py

@@ -9,8 +9,6 @@
   * ComputeNoiseLevels which is very convenient to have
 """
 
-import warnings
-
 import numpy as np
 
 from .sortinganalyzer import AnalyzerExtension, register_result_extension

src/spikeinterface/core/baserecording.py

@@ -4,7 +4,7 @@
 from pathlib import Path
 
 import numpy as np
-from probeinterface import Probe, ProbeGroup, read_probeinterface, select_axes, write_probeinterface
+from probeinterface import read_probeinterface, write_probeinterface
 
 from .base import BaseSegment
 from .baserecordingsnippets import BaseRecordingSnippets

src/spikeinterface/curation/splitunitsorting.py

@@ -1,5 +1,5 @@
 from __future__ import annotations
-from typing import List, Union
+from typing import Union
 
 import numpy as np
 from copy import deepcopy

src/spikeinterface/curation/tests/test_remove_redundant.py

@@ -1,15 +1,7 @@
-import pytest
-import shutil
-from pathlib import Path
-
-import pytest
-
 import numpy as np
 
 from spikeinterface import create_sorting_analyzer
 from spikeinterface.core.generate import inject_some_duplicate_units
-
-
 from spikeinterface.curation.tests.common import make_sorting_analyzer, sorting_analyzer_for_curation
 
 from spikeinterface.curation import remove_redundant_units

src/spikeinterface/extractors/hdsortextractors.py

@@ -4,7 +4,7 @@
 
 import numpy as np
 
-from spikeinterface.core import BaseRecording, BaseSorting, BaseRecordingSegment, BaseSortingSegment
+from spikeinterface.core import BaseSorting, BaseSortingSegment
 from spikeinterface.core.core_tools import define_function_from_class
 from .matlabhelpers import MatlabHelper
 

src/spikeinterface/extractors/iblextractors.py

@@ -4,6 +4,7 @@
 from typing import List, Optional, Union
 from contextlib import redirect_stderr
 from pathlib import Path
+import importlib.util
 
 import numpy as np
 import probeinterface
@@ -13,6 +14,16 @@
 from spikeinterface.extractors.alfsortingextractor import ALFSortingSegment
 
 
+if importlib.util.find_spec("one") is not None and importlib.util.find_spec("one.api") is not None:
+    HAVE_ONE = True
+else:
+    HAVE_ONE = False
+if importlib.util.find_spec("brainbox") is not None and importlib.util.find_spec("brainbox.io.one") is not None:
+    HAVE_BRAINBOX = True
+else:
+    HAVE_BRAINBOX = False
+
+
 class IblRecordingExtractor(BaseRecording):
     """
     Stream IBL data as an extractor object.
@@ -69,10 +80,9 @@ class IblRecordingExtractor(BaseRecording):
 
     @staticmethod
     def _get_default_one(cache_folder: Optional[Union[Path, str]] = None):
-        try:
+        if HAVE_ONE and HAVE_BRAINBOX:
             from one.api import ONE
-            from brainbox.io.one import EphysSessionLoader
-        except ImportError:
+        else:
             raise ImportError(IblRecordingExtractor.installation_mesg)
         one = ONE(
             base_url="https://openalyx.internationalbrainlab.org",
@@ -113,10 +123,9 @@ def get_stream_names(eid: str, cache_folder: Optional[Union[Path, str]] = None,
         stream_names : list of str
             List of stream names as expected by the `stream_name` argument for the class initialization.
         """
-        try:
-            from one.api import ONE
+        if HAVE_ONE and HAVE_BRAINBOX:
             from brainbox.io.one import EphysSessionLoader
-        except ImportError:
+        else:
             raise ImportError(IblRecordingExtractor.installation_mesg)
 
         cache_folder = Path(cache_folder) if cache_folder is not None else cache_folder
@@ -144,9 +153,9 @@ def __init__(
         one: "one.api.OneAlyx" = None,
         stream_type: str | None = None,
     ):
-        try:
+        if HAVE_BRAINBOX:
             from brainbox.io.one import SpikeSortingLoader
-        except ImportError:
+        else:
             raise ImportError(self.installation_mesg)
 
         from neo.rawio.spikeglxrawio import read_meta_file, extract_stream_info
@@ -320,15 +329,15 @@ class IblSortingExtractor(BaseSorting):
     def __init__(
         self, pid: str, good_clusters_only: bool = False, load_unit_properties: bool = True, one=None, **kwargs
     ):
-        try:
+        if HAVE_ONE and HAVE_BRAINBOX:
             from one.api import ONE
             from brainbox.io.one import SpikeSortingLoader
 
             if isinstance(one, dict):
                 one = ONE(**one)
             elif one is None:
                 one = IblRecordingExtractor._get_default_one()
-        except ImportError:
+        else:
             raise ImportError(self.installation_mesg)
         self.ssl = SpikeSortingLoader(one=one, pid=pid)
         sr = self.ssl.raw_electrophysiology(band="ap", stream=True)

src/spikeinterface/extractors/klustaextractors.py

@@ -15,7 +15,7 @@
 
 import numpy as np
 
-from spikeinterface.core import BaseRecording, BaseSorting, BaseRecordingSegment, BaseSortingSegment, read_python
+from spikeinterface.core import BaseSorting, BaseSortingSegment, read_python
 from spikeinterface.core.core_tools import define_function_from_class
 
 

src/spikeinterface/extractors/matlabhelpers.py

@@ -2,6 +2,20 @@
 
 from pathlib import Path
 from collections import deque
+import importlib.util
+
+if importlib.util.find_spec("h5py") is not None and importlib.util.find_spec("scipy") is not None:
+    if importlib.util.find_spec("scipy.io") is not None and importlib.util.find_spec("scipy.io.matlab") is not None:
+        HAVE_MATLAB_HELPERS = True
+    else:
+        HAVE_MATLAB_HELPERS = False
+else:
+    HAVE_MATLAB_HELPERS = False
+
+if importlib.util.find_spec("hdf5storage") is not None:
+    HAVE_HDF5STORAGE = True
+else:
+    HAVE_HDF5STORAGE = False
 
 
 class MatlabHelper:
@@ -11,10 +25,10 @@ class MatlabHelper:
     )  # error message when not installed
 
     def __init__(self, file_path):
-        try:
+        if HAVE_MATLAB_HELPERS:
             import h5py
-            from scipy.io.matlab import loadmat, savemat
-        except ImportError:
+            from scipy.io.matlab import loadmat
+        else:
             raise ImportError(self.installation_mesg)
 
         file_path = Path(file_path) if isinstance(file_path, str) else file_path
@@ -62,12 +76,12 @@ def write_dict_to_mat(cls, mat_file_path, dict_to_write, version="7.3"):  # fiel
             "\n\n pip install hdf5storage\n\n"
         )
 
-        try:
+        if HAVE_HDF5STORAGE:
             import hdf5storage
-        except ImportError:
+        else:
             raise ImportError(hdf5storage_import_error)
 
-        from scipy.io.matlab import loadmat, savemat
+        from scipy.io.matlab import savemat
 
         if version == "7.3":
             hdf5storage.write(dict_to_write, "/", mat_file_path, matlab_compatible=True, options="w")

src/spikeinterface/extractors/mcsh5extractors.py

@@ -1,12 +1,18 @@
 from __future__ import annotations
 
 from pathlib import Path
+import importlib.util
 
 import numpy as np
 
 from spikeinterface.core import BaseRecording, BaseRecordingSegment
 from spikeinterface.core.core_tools import define_function_from_class
 
+if importlib.util.find_spec("h5py") is not None:
+    HAVE_H5PY = True
+else:
+    HAVE_H5PY = False
+
 
 class MCSH5RecordingExtractor(BaseRecording):
     """Load a MCS H5 file as a recording extractor.
@@ -28,9 +34,7 @@ class MCSH5RecordingExtractor(BaseRecording):
 
     def __init__(self, file_path, stream_id=0):
 
-        try:
-            import h5py
-        except ImportError:
+        if not HAVE_H5PY:
             raise ImportError(self.installation_mesg)
 
         self._file_path = file_path

src/spikeinterface/extractors/neoextractors/blackrock.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 from pathlib import Path
-from packaging import version
 from typing import Optional
 
 from spikeinterface.core.core_tools import define_function_from_class