Skip to content

Commit d5f1481

Browse files
authored
Merge pull request #3339 from chrishalcrow/only-allow-above-ks-4-16
Updates to kilosort 4: version >= 4.0.16, `bad_channels`, `clear_cache`, `use_binary_file`
2 parents 24f0541 + fd61bb6 commit d5f1481

12 files changed

Lines changed: 405 additions & 316 deletions

.github/run_tests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ fi
1010

1111
pytest -m "$MARKER" -vv -ra --durations=0 --durations-min=0.001 | tee report.txt; test ${PIPESTATUS[0]} -eq 0 || exit 1
1212
echo "# Timing profile of ${MARKER}" >> $GITHUB_STEP_SUMMARY
13-
python $GITHUB_WORKSPACE/.github/build_job_summary.py report.txt >> $GITHUB_STEP_SUMMARY
13+
python $GITHUB_WORKSPACE/.github/scripts/build_job_summary.py report.txt >> $GITHUB_STEP_SUMMARY
1414
rm report.txt

.github/scripts/check_kilosort4_releases.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,8 @@ def get_pypi_versions(package_name):
1616
response.raise_for_status()
1717
data = response.json()
1818
versions = list(sorted(data["releases"].keys()))
19-
20-
assert parse(spikeinterface.__version__) < parse("0.101.1"), (
21-
"Kilosort 4.0.5-12 are supported in SpikeInterface < 0.101.1."
22-
"At version 0.101.1, this should be updated to support newer"
23-
"kilosort verrsions."
24-
)
25-
versions = [ver for ver in versions if parse("4.0.12") >= parse(ver) >= parse("4.0.5")]
19+
# Filter out versions that are less than 4.0.16
20+
versions = [ver for ver in versions if parse(ver) >= parse("4.0.16")]
2621
return versions
2722

2823

File renamed without changes.

0 commit comments

Comments
 (0)