Edit copy/past from BaseRecording

Author: chrishalcrow

src/spikeinterface/core/basesorting.py

@@ -472,15 +472,15 @@ def frame_slice(self, start_frame, end_frame, check_spike_frames=True):
         )
         return sub_sorting
 
-    def time_slice(self, start_time: float | None, end_time: float) -> BaseSorting:
+    def time_slice(self, start_time: float | None, end_time: float | None) -> BaseSorting:
         """
         Returns a new sorting with sliced time. Note that this operation is not in place.
 
         Parameters
         ----------
-        start_time : float, optional
+        start_time : float | None, default: None
             The start time in seconds. If not provided it is set to 0.
-        end_time : float, optional
+        end_time : float | None, default: None
             The end time in seconds. If not provided it is set to the total duration.
 
         Returns
@@ -491,8 +491,14 @@ def time_slice(self, start_time: float | None, end_time: float) -> BaseSorting:
 
         assert self.get_num_segments() == 1, "Time slicing is only supported for single segment sortings."
 
-        start_frame = self.time_to_sample_index(start_time) if start_time else None
-        end_frame = self.time_to_sample_index(end_time) if end_time else None
+        if self.has_recording():
+            start_frame = self._recording.time_to_sample_index(start_time) if start_time else None
+            end_frame = self._recording.time_to_sample_index(end_time) if end_time else None
+        else:
+            segment = self._sorting_segments[0]
+            t_start = segment._t_start if segment._t_start is not None else 0
+            start_frame = round((start_time - t_start) * self.get_sampling_frequency())
+            end_frame = round((end_time - t_start) * self.get_sampling_frequency())
 
         return self.frame_slice(start_frame=start_frame, end_frame=end_frame)
 

src/spikeinterface/core/tests/test_basesorting.py

@@ -25,7 +25,7 @@
 from spikeinterface.core.testing import check_sorted_arrays_equal, check_sortings_equal
 from spikeinterface.core.generate import generate_sorting
 
-from spikeinterface.core import generate_recording
+from spikeinterface.core import generate_recording, generate_ground_truth_recording
 
 
 def test_BaseSorting(create_cache_folder):
@@ -211,12 +211,27 @@ def test_empty_sorting():
 def test_time_slice():
 
     sampling_frequency = 10_000.0
-    recording = generate_recording(durations=[1.0], num_channels=3, sampling_frequency=sampling_frequency)
 
-    sliced_recording_times = recording.time_slice(start_time=0.1, end_time=0.8)
-    sliced_recording_frames = recording.frame_slice(start_frame=1000, end_frame=8000)
+    # no recording attached to sorting
+    sorting = generate_sorting(durations=[1.0], sampling_frequency=sampling_frequency)
 
-    assert np.allclose(sliced_recording_times.get_traces(), sliced_recording_frames.get_traces())
+    sliced_sorting_times = sorting.time_slice(start_time=0.1, end_time=0.8)
+    sliced_sorting_frames = sorting.frame_slice(start_frame=1000, end_frame=8000)
+
+    assert np.allclose(
+        sliced_sorting_times.to_spike_vector()["sample_index"], sliced_sorting_frames.to_spike_vector()["sample_index"]
+    )
+
+    # with recording
+    recording, sorting = generate_ground_truth_recording(durations=[1.0], sampling_frequency=sampling_frequency)
+    sorting.register_recording(recording)
+
+    sliced_sorting_times = sorting.time_slice(start_time=0.1, end_time=0.8)
+    sliced_sorting_frames = sorting.frame_slice(start_frame=1000, end_frame=8000)
+
+    assert np.allclose(
+        sliced_sorting_times.to_spike_vector()["sample_index"], sliced_sorting_frames.to_spike_vector()["sample_index"]
+    )
 
 
 if __name__ == "__main__":