Skip to content

Skip loading extensions when instantiating benchmarks#3892

Merged
samuelgarcia merged 2 commits into
SpikeInterface:mainfrom
alejoe91:benchmarks-not-load-extensions
May 7, 2025
Merged

Skip loading extensions when instantiating benchmarks#3892
samuelgarcia merged 2 commits into
SpikeInterface:mainfrom
alejoe91:benchmarks-not-load-extensions

Conversation

@alejoe91
Copy link
Copy Markdown
Member

With many cases and large recordings, loading everything in RAM can cause out of mem issues.

We don't really need loading extensions at this point

@alejoe91 alejoe91 requested a review from yger April 29, 2025 07:47
@alejoe91 alejoe91 added the benchmarks Related to benchmarks module label Apr 29, 2025
@alejoe91 alejoe91 added this to the 0.102.3 milestone May 2, 2025
@zm711
Copy link
Copy Markdown
Member

zm711 commented May 5, 2025

Related to this @alejoe91 / @samuelgarcia I think the real heavy extension is the waveforms right? I like to keep my waveforms around (really for provenance), but once I have my templates/PCA done, I don't really want to have to reload them. I can't think of a good mechanism to only autoload the "final" extensions (since that could probably be different for different people), so it would be nice if we could do that, but I guess the only way currently is to not load the extensions and then load them one-by-one?

@chrishalcrow
Copy link
Copy Markdown
Member

Related to this @alejoe91 / @samuelgarcia I think the real heavy extension is the waveforms right? I like to keep my waveforms around (really for provenance), but once I have my templates/PCA done, I don't really want to have to reload them. I can't think of a good mechanism to only autoload the "final" extensions (since that could probably be different for different people), so it would be nice if we could do that, but I guess the only way currently is to not load the extensions and then load them one-by-one?

Agree with @zm711 - we do this in our lab all the time. My proposal: expand the load_extensions to accept lists of strings. E.g.

sa = si.load_sorting_analyzer(
    folder="my_sa", 
    load_extensions=["unit_locations", "templates", "spike_amplitudes"],
)

For another PR though!

@samuelgarcia samuelgarcia merged commit 115c828 into SpikeInterface:main May 7, 2025
15 checks passed
@alejoe91 alejoe91 deleted the benchmarks-not-load-extensions branch March 20, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmarks Related to benchmarks module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants