Fix plot traces when t_start is defined#3893
Merged
alejoe91 merged 3 commits intoApr 29, 2025
Merged
Conversation
zm711
reviewed
Apr 29, 2025
Member
There was a problem hiding this comment.
In line 138 we verify that we have an appropriate segment_index for multisegment? Wouldn't it make sense to move those lines before we do the time vector stuff?
Otherwise this PR looks good to me. So if you'd prefer to discuss in a different PR just let me know.
Member
Author
Totally! Moved in last commit |
Member
Author
|
@zm711 I didn't mean to close it! Probably hit the wrong button eheheh |
Member
|
Works for me, and looks good |
chrishalcrow
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not handling correctly the case when time_vector is None, but t_starts are present