Resolve warnings of NumPy library#3917
Merged
Merged
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
zm711
approved these changes
May 12, 2025
Member
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
This looks fine to me @samuelgarcia you're good with this too?
Thanks for the contribution.
Collaborator
|
This has come before and I think that Sam is ok with it. Let's merge this to save our precious Sam's review time to other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This small PR resolves the NumPy deprecation warnings of
np.in1dwhich you can find in the CI Logs:It also fixes a few typos along the way.