Skip to content

Update TDC2 and SC2 with various improvement in sorting components (clustering + matching)#3923

Merged
alejoe91 merged 67 commits into
SpikeInterface:mainfrom
samuelgarcia:components_merge_templates
Jul 29, 2025
Merged

Update TDC2 and SC2 with various improvement in sorting components (clustering + matching)#3923
alejoe91 merged 67 commits into
SpikeInterface:mainfrom
samuelgarcia:components_merge_templates

Conversation

@samuelgarcia
Copy link
Copy Markdown
Member

@samuelgarcia samuelgarcia commented May 15, 2025 •
edited
Loading

  • low level auto merge using template similarity for sorting components. (This is used in tdc_clustering and cicurs_clustering)
  • smal benchmark clustering improvement
  • rename some clustering method to unify
  • try to improve peak_svd extraction in drift aware context (no succes)
  • simplify tdc-clusering
  • update parameters in tridesclous2
  • update parameters in spykingcircus2
  • add Kilosrt4like sorter, optionally imported if spikeinterface-kilosort-components is installed
  • fix bugs in comparisons when dtype is str
  • speed up collision matching benchmark with a better loop

zm711
zm711 reviewed May 15, 2025
View reviewed changes
Comment thread src/spikeinterface/sortingcomponents/clustering/merge.py
@samuelgarcia samuelgarcia added the sortingcomponents Related to sortingcomponents module label Jun 17, 2025
@samuelgarcia samuelgarcia changed the title Components merge templates Various improvement in sorting components clustering side Jun 17, 2025
@samuelgarcia samuelgarcia changed the title Various improvement in sorting components clustering side Various improvement in sorting components clustering + matching Jun 17, 2025
alejoe91
alejoe91 reviewed Jul 28, 2025
View reviewed changes
Comment thread src/spikeinterface/sorters/internal/spyking_circus2.py
"chunk_preprocessing": {"memory_limit": None},
"multi_units_only": False,
"job_kwargs": {"n_jobs": 0.75},
"job_kwargs": {},
Copy link
Copy Markdown
Member

@alejoe91 alejoe91 Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to upgrade SC2 version!

alejoe91
alejoe91 previously requested changes Jul 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@alejoe91 alejoe91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade SC2 version!

@samuelgarcia
Copy link
Copy Markdown
Member Author

samuelgarcia commented Jul 28, 2025

Upgrade SC2 version!

I did a YYYY.MM versioning for both SC2 and TDC2 I will think this will be easier to follow.

@yger yger dismissed alejoe91’s stale review July 29, 2025 09:55

This has been implemented by Sam as YYYY.MM

@alejoe91
Copy link
Copy Markdown
Member

alejoe91 commented Jul 29, 2025

ok to squash and merge @samuelgarcia @yger ?

@samuelgarcia
Copy link
Copy Markdown
Member Author

samuelgarcia commented Jul 29, 2025

I would prefer no squash.
The history is quite consitent.

@alejoe91 alejoe91 merged commit c398228 into SpikeInterface:main Jul 29, 2025
15 checks passed
@samuelgarcia samuelgarcia deleted the components_merge_templates branch July 29, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zm711 zm711 zm711 left review comments

@yger yger yger approved these changes

@alejoe91 alejoe91 alejoe91 left review comments

Assignees

No one assigned

Labels

sortingcomponents Related to sortingcomponents module

Projects

None yet

Milestone

0.103.0

Development

Successfully merging this pull request may close these issues.

4 participants

@samuelgarcia @yger @alejoe91 @zm711