Skip to content

Allow for recordingless benchmarks #3957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejoe91 merged 1 commit into from
Jun 2, 2025
Merged

Allow for recordingless benchmarks #3957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/spikeinterface/benchmark/benchmark_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,6 @@ def create(cls, study_folder, datasets={}, cases={}, levels=None):
else:
analyzer = data

rec, gt_sorting = analyzer.recording, analyzer.sorting

analyzers_path[key] = str(analyzer.folder.resolve())

# recordings are pickled
Expand Down Expand Up @@ -180,7 +178,11 @@ def scan_folder(self):
self.analyzers[key] = analyzer
# the sorting is in memory here we take the saved one because comparisons need to pickle it later
sorting = load(analyzer.folder / "sorting")
self.datasets[key] = analyzer.recording, sorting
if analyzer.has_recording():
recording = analyzer.recording
else:
recording = None
self.datasets[key] = recording, sorting

with open(self.folder / "cases.pickle", "rb") as f:
self.cases = pickle.load(f)
Expand Down