Fix double definition of openephys warnings#3980
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes a redundant inline import of the warnings module in the OpenEphys extractor’s deprecation warning block.
- Removed the duplicated
import warningsinside theif load_sync_channel:block - Left the deprecation message assignment unchanged
Comments suppressed due to low confidence (2)
src/spikeinterface/extractors/neoextractors/openephys.py:163
- The deprecation message is assigned to
warning_messagebut never emitted. Add a call towarnings.warn(warning_message, DeprecationWarning)(or a logger) after constructing the message to actually surface the deprecation warning.
warning_message = (
src/spikeinterface/extractors/neoextractors/openephys.py:163
- Consider adding a unit test to verify that the deprecation warning is emitted when
load_sync_channelis true, ensuring this behavior remains covered.
warning_message = (
Member
Author
|
This actually results in an |
zm711
approved these changes
Jun 10, 2025
zm711
left a comment
Member
There was a problem hiding this comment.
That's really weird. I thought it would just find the package in some sort of python cache.... But doesn't hurt to delete unnecessary import :)
Member
Author
|
@vncntprvst FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.