Skip to content

try to fix pyedflib on tests #3986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samuelgarcia wants to merge 6 commits into from
Closed

try to fix pyedflib on tests #3986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8b927aa
try to fix pyedflib on tests
samuelgarcia Jun 16, 2025
fe3c4c2
oups
samuelgarcia Jun 16, 2025
0a4787b
bad syntax
samuelgarcia Jun 16, 2025
ba2dd11
finally remove pyedf for py3.13 because tests are failing
samuelgarcia Jun 16, 2025
3062fcb
skip when pyedflib is not installed
samuelgarcia Jun 16, 2025
df874d5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ extractors = [
"MEArec>=1.8",
"pynwb>=2.6.0",
"hdmf-zarr>=0.11.0",
"pyedflib>=0.1.30",
#"pyedflib>=0.1.30",
"pyedflib>=0.1.30; python_version<'3.13'", # tests are failling with py3.13
"sonpy;python_version<'3.10'",
"lxml", # lxml for neuroscope
"scipy",
Expand Down
9 changes: 9 additions & 0 deletions src/spikeinterface/extractors/tests/test_neoextractors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,15 @@ class AlphaOmegaEventTest(EventCommonTestSuite, unittest.TestCase):
]


try:
import pyedflib

HAVE_PYEDF = True
except:
HAVE_PYEDF = False


@pytest.mark.skipif(not (HAVE_PYEDF), reason="pyedflib is not installed")
class EDFRecordingTest(RecordingCommonTestSuite, unittest.TestCase):
ExtractorClass = EDFRecordingExtractor
downloads = ["edf"]
Expand Down
Loading