Fix last mock call to slurm launcher#3988
Merged
Merged
Conversation
zm711
approved these changes
Jun 16, 2025
Member
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
Works for me. I guess my only question would be the benefit of adding the folder path is that we test that the file goes to the correct place in the give tempdir rather than just check that the script is in a random place?
Member
Author
|
Yes, but Sam's fix is also ok but this checks the folder location too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.