Skip to content

Fix last mock call to slurm launcher #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejoe91 merged 2 commits into from
Jun 17, 2025
Merged

Fix last mock call to slurm launcher #3988

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd7d1a0
Fix last mock call to slurm launcher
alejoe91 Jun 16, 2025
d2fcaa5
Merge branch 'main' into fix-slurm-tests
alejoe91 Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/spikeinterface/sorters/tests/test_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ def test_run_sorter_jobs_slurm_kwargs(mocker, tmp_path, job_list):
engine="slurm",
engine_kwargs=None,
)
tmp_script_folder = "_".join(tempfile.mkdtemp(prefix="spikeinterface_slurm_").split("_")[:-1])
assert tmp_script_folder in mock_subprocess_run.call_args_list[-1].args[0][5]
tmp_script_folder = Path(tempfile.gettempdir()) / "spikeinterface_slurm_"
assert str(tmp_script_folder) in mock_subprocess_run.call_args_list[-1].args[0][5]


def test_run_sorter_by_property(create_cache_folder):
Expand Down
Loading