First pass of deprecation removals for 0.103.0#3993
Conversation
|
What I haven't changed 1) our the waveform extractor combability. It was listened as maybe remove for 0.103.0 but I say keep--maybe to discuss at a maintenance meeting |
|
I would like to suggest as we update deprecations (myself included) that we try to add a comment in the tests as well with the deprecation version to make it easier to find. I tried searching based on deprecation term, but missed a few in testing as we can see from the failed testing. I think the extra effort will speed this along moving forward :) |
h-mayorquin
left a comment
There was a problem hiding this comment.
LGTM. The faster we merge this the better so people can tell us if nothing break.
|
Poor hugging-face :( |
|
IBL testing is now failing. @alejoe91 I remember we had this issue before with some sort of versioning. Do you know anything about this? |
|
C'est un beau menage de primtemps. I am OK for merging soon. |
|
@zm711 ok to merge? |
|
Yes I would say merge. In a separate PR I need to
But I think both of those things can be separate. It is a real pain to make these dep PRs too big because the testing burden is huge. So I think small chunks are better. |
I just did a search of the code base for all our dep warnings for removals in 0.103.0 and removed, updated some docs related to the deps and fixed tests that I could find. I probably missed something so I'll keep it on draft for the moment.