Allow white matter recording to pass gain_to_uV#4008
Merged
alejoe91 merged 2 commits intoJun 25, 2025
Conversation
h-mayorquin
changed the title
Member
|
If there will always be an xml file (and Paul's example was someone who accidentally threw away the xml) it seems like we should make a proper extractor, no? I think this is fine for now. But this might be the case where we parse the xml if we can and if not we tell people to just use binary recording extractor. |
Collaborator
Author
|
Yes, we have all the files now. It would be good to implement parsing of the metadata from xml if those files are available but at the moment I don't have time and it is better to enable this feature earlier rather than later. |
alejoe91
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3964