Skip to content

Fix false-positive margin warning in forkserver workers #4506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
h-mayorquin wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

Fix false-positive margin warning in forkserver workers #4506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/spikeinterface/core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
get_global_job_kwargs,
set_global_job_kwargs,
reset_global_job_kwargs,
is_set_global_job_kwargs_set,
)

# tools
Expand Down
9 changes: 7 additions & 2 deletions src/spikeinterface/preprocessing/filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@
import numpy as np

from spikeinterface.core.core_tools import define_function_handling_dict_from_class
from spikeinterface.core import get_chunk_with_margin, ensure_chunk_size, get_global_job_kwargs
from spikeinterface.core import (
get_chunk_with_margin,
ensure_chunk_size,
get_global_job_kwargs,
is_set_global_job_kwargs_set,
)

from .basepreprocessor import BasePreprocessor, BasePreprocessorSegment

Expand Down Expand Up @@ -118,7 +123,7 @@ def __init__(
margin = int(margin_ms * fs / 1000.0)

global_job_kwargs_chunk_size = ensure_chunk_size(recording, **get_global_job_kwargs())
if margin > MARGIN_TO_CHUNK_PERCENT_WARNING * global_job_kwargs_chunk_size:
if is_set_global_job_kwargs_set() and margin > MARGIN_TO_CHUNK_PERCENT_WARNING * global_job_kwargs_chunk_size:
warnings.warn(
f"The margin size ({margin} samples) is more than {int(MARGIN_TO_CHUNK_PERCENT_WARNING * 100)}% "
f"of the global chunk size {global_job_kwargs_chunk_size} samples. This may lead to performance bottlenecks when "
Expand Down
Loading