Check the external ID key parameter before searching it in the external keys array

petaak · petaak · commit cac97ebc22f0 · 2026-03-22T19:49:53.000+01:00
In PHP 8.5 passing null as the key parameter for array_key_exists() is deprecated.
diff --git a/src/AbraFlexi/RO.php b/src/AbraFlexi/RO.php
@@ -2137,7 +2137,7 @@ public function getExternalID($want = null)
     {
         $ids = (array) $this->getExternalIDs();
 
-        return \array_key_exists($want, $ids) ? $ids[$want] : current($ids);
+        return $want !== null && \array_key_exists($want, $ids) ? $ids[$want] : current($ids);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -2137,7 +2137,7 @@ public function getExternalID($want = null)`
`2137`	`2137`	`{`
`2138`	`2138`	`$ids = (array) $this->getExternalIDs();`
`2139`	`2139`
`2140`		`- return \array_key_exists($want, $ids) ? $ids[$want] : current($ids);`
	`2140`	`+ return $want !== null && \array_key_exists($want, $ids) ? $ids[$want] : current($ids);`
`2141`	`2141`	`}`
`2142`	`2142`
`2143`	`2143`	`/**`