Skip to content

Commit b1c07f0

Browse files
committed
fix(ci): build PyPI artifacts in pypi-dist/ to avoid dist/scripts collision
The pypa/gh-action-pypi-publish action uploads everything in its packages-dir, but dist/scripts/ already exists in the repo as the location of helper scripts referenced by setup.py. Twine's metadata check rejected dist/scripts as an unknown distribution format and the publish step failed before uploading anything. Build sdist/wheel into pypi-dist/ instead and point the action there. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
1 parent e303c99 commit b1c07f0

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

.github/workflows/build.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,11 @@ jobs:
6565
./node_modules/.bin/gulp clean
6666
./node_modules/.bin/gulp theme:build
6767
- name: Setup for publishing
68-
run: python setup.py sdist bdist_wheel
68+
run: python setup.py sdist bdist_wheel --dist-dir=pypi-dist
6969
- name: Publish
7070
uses: pypa/gh-action-pypi-publish@release/v1
71+
with:
72+
packages-dir: pypi-dist
7173

7274
publish-docker:
7375
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)