Commit a86409a
Revert MapOutputRectToInputRects sub-rect propagation
Earlier today (1ea4365) I changed CustomPixelShaderEffect::Map-
OutputRectToInputRects to honor the queried output sub-rect, hoping it
would unlock leaf-side preview-resolution scaling and per-input-rect
routing for Split. The Split-pivot regression check passed at full-
canvas preview, but the broader sub-rect propagation breaks thumbnail-
sized preview panes: D2D queries a small output sub-rect to fill the
thumbnail, our chain dutifully renders only that sub-rect, and the
preview pane shows a small rendered region in the upper-left of an
otherwise-black canvas. User-reported via Gamut Highlight thumbnail.
Going back to the safe baseline -- always return m_lastOutputRect from
MapOutputRectToInputRects regardless of queried sub-rect. This guarantees
the intermediate textures match the full effect output rect (the with-
TRIVIAL_SAMPLING contract) and keeps thumbnail / preview-pane rendering
correct.
Trade-off: D2Ds lazy-eval cant propagate sub-rect demand through our
chain, so leaf-side approaches to preview-resolution scaling cant
rely on this mechanism. The Scale catalog node ships the explicit-
insertion model instead -- which is what we landed on anyway after the
B/C architecture options were abandoned.
Tier 2 (per-input-rect routing for Split) would still need this
mechanism but it was already deferred indefinitely.
154/154 tests pass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent bcd89d8 commit a86409a
1 file changed
Lines changed: 16 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
252 | 252 | | |
253 | 253 | | |
254 | 254 | | |
255 | | - | |
| 255 | + | |
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
263 | 265 | | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
277 | 274 | | |
278 | 275 | | |
279 | | - | |
| 276 | + | |
280 | 277 | | |
281 | 278 | | |
282 | 279 | | |
| |||
0 commit comments