Add DDA and WGC capture sources#1
Merged
Merged
Conversation
Spruill-1
reviewed
May 6, 2026
| @@ -0,0 +1,316 @@ | |||
| #include "pch_engine.h" | |||
Owner
There was a problem hiding this comment.
This is a great addition - didn't even occur to me.
Spruill-1
added a commit
that referenced
this pull request
May 7, 2026
Decision #32 (Day 6) removed the built-in tone-mapper from the render path; the class itself lingered as default-None dead code through v1.4.1 -- never instantiated at runtime, only included by Controls/OutputWindow.h for an unused declaration. The .github/copilot-instructions.md still cited "fixing issues with the existing D2D tonemapper effect" as the project #1 development focus, which was actively misleading new contributors and AI agents about where work actually happens. - Delete Rendering/ToneMapper.h and Rendering/ToneMapper.cpp (~280 LoC). - Remove the unused #include from Controls/OutputWindow.h. - Drop entries from ShaderLab.vcxproj, ShaderLabEngine.vcxproj, ShaderLab.vcxproj.filters. - Rewrite the project-identity, architecture, and tone-mapping focus sections of .github/copilot-instructions.md around graph-built tone mappers (the ICtCp suite) and the empirical fidelity loop (Working Space + Delta E Comparator Grayscale dE + Luminance Statistics). Also fix the architecture diagram, namespace-convention bullet, and the two enum/class examples that referenced ToneMapMode / ToneMapper. - Update README architecture mermaid (drop ToneMapper from EV node). - Add README decision log entry #54 explaining the retirement and where new tone-mapping work goes. - Update .context/resume.md rendering bullet and project-structure tree. - Add CHANGELOG [Unreleased] entry. Build clean. All 58 ShaderLabTests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Spruill-1
added a commit
that referenced
this pull request
May 7, 2026
Single Effects::PackPropertyToCBuffer helper in Effects/ShaderCompiler.h/.cpp that converts a PropertyValue to the destination cbuffer slot's declared HLSL type. The historical "memcpy of float bit pattern produces nonsense uints" bug class (CHANGELOG 1.3.9) cannot recur because the helper reflects each variable's D3D_SHADER_VARIABLE_TYPE and static_cast<uint32_t> / <int32_t> / BOOL before writing. Three previously-duplicated pack sites now share this single implementation: CustomPixelShaderEffect::PackConstantBuffer, CustomComputeShaderEffect::PackConstantBuffer, and the D3D11 compute path inside GraphEvaluator::DispatchUserD3D11Compute. CLAUDE.md gotcha #1 ("uint cbuffer params don't work") replaced with positive-guidance note: HLSL can now declare uint/int/bool enums with clean Mode == 1 comparisons. Existing 13 ShaderLab effects keep their float-enum convention -- migration is optional and deferred (queued as morning question). Build clean. All 109 ShaderLabTests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.