Skip to content

Update setup.py get_version() is called twice unnecessarily#25

Open
subhshrivastava29918 wants to merge 1 commit into
Squarespace:masterfrom
subhshrivastava29918:patch-1
Open

Update setup.py get_version() is called twice unnecessarily#25
subhshrivastava29918 wants to merge 1 commit into
Squarespace:masterfrom
subhshrivastava29918:patch-1

Conversation

@subhshrivastava29918
Copy link
Copy Markdown

In the setup() call, get_version() is invoked twice — once for version= and once for download_url=. This means the file is opened and parsed twice, which is inefficient and fragile (if the file changes between calls, you'd get inconsistent results)

In the setup() call, get_version() is invoked twice — once for version= and once for download_url=. This means the file is opened and parsed twice, which is inefficient and fragile (if the file changes between calls, you'd get inconsistent results)
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@subhshrivastava29918
Copy link
Copy Markdown
Author

That is there and I have corrected in this code a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants