sync write; new _\r\n failing test

Author: mgravell

tests/RESPite.Tests/RespScannerTests.cs

@@ -0,0 +1,18 @@
+using RESPite.Messages;
+using Xunit;
+
+namespace RESPite.Tests;
+
+public class RespScannerTests
+{
+    [Fact]
+    public void ScanNull()
+    {
+        RespScanState scanner = default;
+        Assert.True(scanner.TryRead("_\r\n"u8, out var consumed));
+
+        Assert.Equal(3, consumed);
+        Assert.Equal(3, scanner.TotalBytes);
+        Assert.Equal(RespPrefix.Null, scanner.Prefix);
+    }
+}

toys/StackExchange.Redis.Server/RedisServer.cs

@@ -433,6 +433,10 @@ protected virtual TypedRedisValue ClientReply(RedisClient client, in RedisReques
         protected virtual TypedRedisValue ClientId(RedisClient client, in RedisRequest request)
             => TypedRedisValue.Integer(client.Id);
 
+        [RedisCommand(4, nameof(RedisCommand.CLIENT), "setinfo", LockFree = true)]
+        protected virtual TypedRedisValue ClientSetInfo(RedisClient client, in RedisRequest request)
+            => TypedRedisValue.OK; // only exists to keep logs clean
+
         private bool IsClusterEnabled(out TypedRedisValue fault)
         {
             if (ServerType == ServerType.Cluster)

toys/StackExchange.Redis.Server/RespServer.cs

@@ -285,6 +285,7 @@ public async Task RunClientAsync(IDuplexPipe pipe, RedisServer.Node node = null,
             {
                 node ??= DefaultNode;
                 client = AddClient(node, state);
+
                 while (!client.Closed)
                 {
                     var readResult = await pipe.Input.ReadAsync().ConfigureAwait(false);
@@ -298,7 +299,8 @@ public async Task RunClientAsync(IDuplexPipe pipe, RedisServer.Node node = null,
                         var response = Execute(client, request);
                         client.ResetAfterRequest();
 
-                        await WriteResponseAsync(client, pipe.Output, response, client.Protocol);
+                        WriteResponse(client, pipe.Output, response, client.Protocol);
+                        await pipe.Output.FlushAsync().ConfigureAwait(false);
 
                         // advance the buffer to account for the message we just read
                         buffer = buffer.Slice(consumed);
@@ -344,7 +346,7 @@ public virtual void Log(string message)
             }
         }
 
-        public static async ValueTask WriteResponseAsync(RedisClient client, PipeWriter output, TypedRedisValue value, RedisProtocol protocol)
+        public static void WriteResponse(RedisClient client, IBufferWriter<byte> output, TypedRedisValue value, RedisProtocol protocol)
         {
             static void WritePrefix(IBufferWriter<byte> output, char prefix)
             {
@@ -421,7 +423,7 @@ static void WritePrefix(IBufferWriter<byte> output, char prefix)
                                 throw new InvalidOperationException("Array element cannot be nil, index " + i);
 
                             // note: don't pass client down; this would impact SkipReplies
-                            await WriteResponseAsync(null, output, item, protocol);
+                            WriteResponse(null, output, item, protocol);
                         }
                         break;
                     default:
@@ -438,8 +440,6 @@ static void WritePrefix(IBufferWriter<byte> output, char prefix)
                 }
             }
 
-            await output.FlushAsync().ConfigureAwait(false);
-
             static RespPrefix ToResp2(RespPrefix type)
             {
                 switch (type)