Use a better way of refing the build project

Author: mgravell

.github/workflows/CI.yml

@@ -31,8 +31,6 @@ jobs:
             6.0.x
             8.0.x
             10.0.x
-      - name: .NET Build (eng prebuild)
-        run: dotnet build eng/StackExchange.Redis.Build/StackExchange.Redis.Build.csproj -c Release /p:CI=true
       - name: .NET Build
         run: dotnet build Build.csproj -c Release /p:CI=true
       - name: StackExchange.Redis.Tests
@@ -134,8 +132,6 @@ jobs:
           redis-cli -p 26381 INFO SERVER | grep redis_version || echo "Failed to get version for port 26381"
         continue-on-error: true
 
-      - name: .NET Build (eng prebuild)
-        run: dotnet build eng/StackExchange.Redis.Build/StackExchange.Redis.Build.csproj -c Release /p:CI=true
       - name: .NET Build
         run: dotnet build Build.csproj -c Release /p:CI=true
       - name: StackExchange.Redis.Tests

.github/workflows/codeql.yml

@@ -53,10 +53,6 @@ jobs:
           # For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
           # queries: security-extended,security-and-quality
 
-      - if: matrix.language == 'csharp'
-        name: .NET Build (eng prebuild)
-        run: dotnet build eng/StackExchange.Redis.Build/StackExchange.Redis.Build.csproj -c Release /p:CI=true
-
       - if: matrix.language == 'csharp'
         name: .NET Build
         run: dotnet build Build.csproj -c Release /p:CI=true

Directory.Build.props

@@ -42,4 +42,11 @@
     <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="all" />
     <PackageReference Include="StyleCop.Analyzers" PrivateAssets="All" />
   </ItemGroup>
+  
+  <ItemGroup>
+    <!-- for everything except the build project itself: use the build project as an analyzer -->
+    <ProjectReference Condition="'$(AssemblyName)' != 'StackExchange.Redis.Build'"
+                      Include="..\..\eng\StackExchange.Redis.Build\StackExchange.Redis.Build.csproj"
+                      OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
+  </ItemGroup>
 </Project>

src/Directory.Build.props

@@ -11,7 +11,4 @@
     <PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="all" />
     <PackageReference Include="Nerdbank.GitVersioning" PrivateAssets="all" Condition=" '$(DEVCONTAINER)' != 'true' " />
   </ItemGroup>
-  <ItemGroup>
-    <Analyzer Include="..\..\eng\StackExchange.Redis.Build\bin\$(Configuration)\netstandard2.0\StackExchange.Redis.Build.dll" />
-  </ItemGroup>
 </Project>

src/RESPite/RESPite.csproj

@@ -19,8 +19,6 @@
   <ItemGroup>
     <InternalsVisibleTo Include="RESPite.Tests"/>
     <None Include="readme.md" Pack="true" PackagePath="/"/>
-    <None Include="../../eng/StackExchange.Redis.Build/bin/$(Configuration)/netstandard2.0/StackExchange.Redis.Build.dll" Pack="true" PackagePath="analyzers/dotnet" Visible="true"
-      Link="Shared/StackExchange.Redis.Build.dll"/>
   </ItemGroup>
 
   <ItemGroup>

src/StackExchange.Redis/StackExchange.Redis.csproj

@@ -54,10 +54,6 @@
     <InternalsVisibleTo Include="StackExchange.Redis.Tests" />
   </ItemGroup>
 
-  <ItemGroup>
-    <ProjectReference Include="..\..\eng\StackExchange.Redis.Build\StackExchange.Redis.Build.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
-  </ItemGroup>
-
   <ItemGroup>
     <!-- before v3, we don't have an actual reference to RESPite, so let's share the minimal files -->
     <Compile Include="..\RESPite\Shared\AsciiHash.cs" Link="Shared\AsciiHash.cs" />

tests/StackExchange.Redis.Benchmarks/StackExchange.Redis.Benchmarks.csproj

@@ -13,6 +13,5 @@
     <ProjectReference Include="..\..\src\RESPite\RESPite.csproj" />
     <!-- removing this for now, due to conflicting AsciiHash -->
     <!-- <ProjectReference Include="..\..\src\StackExchange.Redis\StackExchange.Redis.csproj" /> -->
-    <ProjectReference Include="..\..\eng\StackExchange.Redis.Build\StackExchange.Redis.Build.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
   </ItemGroup>
 </Project>

tests/StackExchange.Redis.Tests/StackExchange.Redis.Tests.csproj

@@ -33,6 +33,5 @@
     <PackageReference Include="xunit.runner.visualstudio" PrivateAssets="all" />
     <PackageReference Include="System.IO.Compression" />
     <PackageReference Include="System.IO.Pipelines" />
-    <ProjectReference Include="..\..\eng\StackExchange.Redis.Build\StackExchange.Redis.Build.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
   </ItemGroup>
 </Project>

toys/StackExchange.Redis.Server/StackExchange.Redis.Server.csproj

@@ -15,6 +15,5 @@
     <ProjectReference Include="..\..\src\StackExchange.Redis\StackExchange.Redis.csproj" Aliases="seredis"/>
     <ProjectReference Include="..\..\src\RESPite\RESPite.csproj" />
     <PackageReference Include="System.Runtime.Caching" />
-    <ProjectReference Include="..\..\eng\StackExchange.Redis.Build\StackExchange.Redis.Build.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
   </ItemGroup>
 </Project>