stop loop on dispose

Author: mgravell

src/StackExchange.Redis/MultiGroupMultiplexer.cs

@@ -21,9 +21,9 @@ public partial class ConnectionMultiplexer
     /// <param name="members">The initial configurations to connect to.</param>
     /// <param name="options">Additional options for configuring this group.</param>
     /// <param name="log">The <see cref="TextWriter"/> to log to.</param>
-#pragma warning disable RS0016, RS0026
+#pragma warning disable RS0026
     public static Task<IConnectionGroup> ConnectGroupAsync(ConnectionGroupMember[] members, MultiGroupOptions? options = null, TextWriter? log = null)
-#pragma warning restore RS0016, RS0026
+#pragma warning restore RS0026
     {
         // create a defensive copy of the array; we don't want callers being able to radically swap things!
         members = (ConnectionGroupMember[])members.Clone();
@@ -40,13 +40,13 @@ public static Task<IConnectionGroup> ConnectGroupAsync(ConnectionGroupMember[] m
     /// <param name="member1">An additional initial configuration to connect to.</param>
     /// <param name="options">Additional options for configuring this group.</param>
     /// <param name="log">The <see cref="TextWriter"/> to log to.</param>
-#pragma warning disable RS0016, RS0026
+#pragma warning disable RS0026
     public static Task<IConnectionGroup> ConnectGroupAsync(
         ConnectionGroupMember member0,
         ConnectionGroupMember member1,
         MultiGroupOptions? options = null,
         TextWriter? log = null)
-#pragma warning restore RS0016, RS0026
+#pragma warning restore RS0026
     {
         options ??= MultiGroupOptions.Default;
         options.Freeze();
@@ -326,6 +326,7 @@ static bool TrySelectPreferredGroup(WeakReference weakRef)
             {
                 try
                 {
+                    if (typed.IsDisposed) return false;
                     typed.SelectPreferredGroup();
                 }
                 catch (Exception ex)
@@ -338,8 +339,11 @@ static bool TrySelectPreferredGroup(WeakReference weakRef)
         }
     }
 
+    internal bool IsDisposed => _disposed;
+
     internal void SelectPreferredGroup()
     {
+        if (_disposed) return;
         var previousMuxer = _active;
         ConnectionGroupMember? preferredMember = null, previousMember = null;
         var members = _members;

src/StackExchange.Redis/PublicAPI/PublicAPI.Unshipped.txt

@@ -29,6 +29,8 @@ StackExchange.Redis.MultiGroupOptions
 StackExchange.Redis.MultiGroupOptions.CheckInterval.get -> System.TimeSpan
 StackExchange.Redis.MultiGroupOptions.CheckInterval.set -> void
 StackExchange.Redis.MultiGroupOptions.MultiGroupOptions() -> void
+static StackExchange.Redis.ConnectionMultiplexer.ConnectGroupAsync(StackExchange.Redis.ConnectionGroupMember! member0, StackExchange.Redis.ConnectionGroupMember! member1, StackExchange.Redis.MultiGroupOptions? options = null, System.IO.TextWriter? log = null) -> System.Threading.Tasks.Task<StackExchange.Redis.IConnectionGroup!>!
+static StackExchange.Redis.ConnectionMultiplexer.ConnectGroupAsync(StackExchange.Redis.ConnectionGroupMember![]! members, StackExchange.Redis.MultiGroupOptions? options = null, System.IO.TextWriter? log = null) -> System.Threading.Tasks.Task<StackExchange.Redis.IConnectionGroup!>!
 static StackExchange.Redis.MultiGroupOptions.Default.get -> StackExchange.Redis.MultiGroupOptions!
 override StackExchange.Redis.LCSMatchResult.LCSMatch.Equals(object? obj) -> bool
 override StackExchange.Redis.LCSMatchResult.LCSMatch.GetHashCode() -> int