Skip to content

Commit 46b60b3

Browse files
mgravellmgravell
authored
Remove GCRA and stabilize CI (#3074)
* limit keyspace events to AKE until 8.8 lands * improve sln layout * yank GCRA * prefer slnx and re-apply folder fixes * release notes
1 parent 8e72ad4 commit 46b60b3

37 files changed

Lines changed: 51 additions & 870 deletions

StackExchange.Redis.sln renamed to StackExchange.Redis.sln.old

Lines changed: 14 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -24,71 +24,16 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
2424
.github\workflows\codeql.yml = .github\workflows\codeql.yml
2525
EndProjectSection
2626
EndProject
27-
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "RedisConfigs", "RedisConfigs", "{96E891CD-2ED7-4293-A7AB-4C6F5D8D2B05}"
28-
ProjectSection(SolutionItems) = preProject
29-
tests\RedisConfigs\cli-master.cmd = tests\RedisConfigs\cli-master.cmd
30-
tests\RedisConfigs\cli-secure.cmd = tests\RedisConfigs\cli-secure.cmd
31-
tests\RedisConfigs\cli-slave.cmd = tests\RedisConfigs\cli-slave.cmd
32-
tests\RedisConfigs\docker-compose.yml = tests\RedisConfigs\docker-compose.yml
33-
tests\RedisConfigs\Dockerfile = tests\RedisConfigs\Dockerfile
34-
tests\RedisConfigs\start-all.cmd = tests\RedisConfigs\start-all.cmd
35-
tests\RedisConfigs\start-all.sh = tests\RedisConfigs\start-all.sh
36-
tests\RedisConfigs\start-basic.cmd = tests\RedisConfigs\start-basic.cmd
37-
tests\RedisConfigs\start-basic.sh = tests\RedisConfigs\start-basic.sh
38-
tests\RedisConfigs\start-cluster.cmd = tests\RedisConfigs\start-cluster.cmd
39-
tests\RedisConfigs\start-sentinel.cmd = tests\RedisConfigs\start-sentinel.cmd
40-
tests\RedisConfigs\wsl2.md = tests\RedisConfigs\wsl2.md
41-
EndProjectSection
42-
EndProject
4327
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "StackExchange.Redis", "src\StackExchange.Redis\StackExchange.Redis.csproj", "{EF84877F-59BE-41BE-9013-E765AF0BB72E}"
4428
EndProject
4529
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "StackExchange.Redis.Tests", "tests\StackExchange.Redis.Tests\StackExchange.Redis.Tests.csproj", "{3B8BD8F1-8BFC-4D8C-B4DA-25FFAF3D1DBE}"
4630
EndProject
4731
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "BasicTest", "tests\BasicTest\BasicTest.csproj", "{939FA5F7-16AA-4847-812B-6EBC3748A86D}"
4832
EndProject
49-
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Sentinel", "Sentinel", "{36255A0A-89EC-43C8-A642-F4C1ACAEF5BC}"
50-
ProjectSection(SolutionItems) = preProject
51-
tests\RedisConfigs\Sentinel\redis-7010.conf = tests\RedisConfigs\Sentinel\redis-7010.conf
52-
tests\RedisConfigs\Sentinel\redis-7011.conf = tests\RedisConfigs\Sentinel\redis-7011.conf
53-
tests\RedisConfigs\Sentinel\sentinel-26379.conf = tests\RedisConfigs\Sentinel\sentinel-26379.conf
54-
tests\RedisConfigs\Sentinel\sentinel-26380.conf = tests\RedisConfigs\Sentinel\sentinel-26380.conf
55-
tests\RedisConfigs\Sentinel\sentinel-26381.conf = tests\RedisConfigs\Sentinel\sentinel-26381.conf
56-
EndProjectSection
57-
EndProject
58-
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Cluster", "Cluster", "{A3B4B972-5BD2-4D90-981F-7E51E350E628}"
59-
ProjectSection(SolutionItems) = preProject
60-
tests\RedisConfigs\Cluster\cluster-7000.conf = tests\RedisConfigs\Cluster\cluster-7000.conf
61-
tests\RedisConfigs\Cluster\cluster-7001.conf = tests\RedisConfigs\Cluster\cluster-7001.conf
62-
tests\RedisConfigs\Cluster\cluster-7002.conf = tests\RedisConfigs\Cluster\cluster-7002.conf
63-
tests\RedisConfigs\Cluster\cluster-7003.conf = tests\RedisConfigs\Cluster\cluster-7003.conf
64-
tests\RedisConfigs\Cluster\cluster-7004.conf = tests\RedisConfigs\Cluster\cluster-7004.conf
65-
tests\RedisConfigs\Cluster\cluster-7005.conf = tests\RedisConfigs\Cluster\cluster-7005.conf
66-
tests\RedisConfigs\Cluster\nodes-7000.conf = tests\RedisConfigs\Cluster\nodes-7000.conf
67-
tests\RedisConfigs\Cluster\nodes-7001.conf = tests\RedisConfigs\Cluster\nodes-7001.conf
68-
tests\RedisConfigs\Cluster\nodes-7002.conf = tests\RedisConfigs\Cluster\nodes-7002.conf
69-
tests\RedisConfigs\Cluster\nodes-7003.conf = tests\RedisConfigs\Cluster\nodes-7003.conf
70-
tests\RedisConfigs\Cluster\nodes-7004.conf = tests\RedisConfigs\Cluster\nodes-7004.conf
71-
tests\RedisConfigs\Cluster\nodes-7005.conf = tests\RedisConfigs\Cluster\nodes-7005.conf
72-
EndProjectSection
73-
EndProject
74-
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Basic", "Basic", "{38BDEEED-7BEB-4B1F-9CE0-256D63F9C502}"
75-
ProjectSection(SolutionItems) = preProject
76-
tests\RedisConfigs\Basic\primary-6379.conf = tests\RedisConfigs\Basic\primary-6379.conf
77-
tests\RedisConfigs\Basic\replica-6380.conf = tests\RedisConfigs\Basic\replica-6380.conf
78-
tests\RedisConfigs\Basic\secure-6381.conf = tests\RedisConfigs\Basic\secure-6381.conf
79-
tests\RedisConfigs\Basic\tls-ciphers-6384.conf = tests\RedisConfigs\Basic\tls-ciphers-6384.conf
80-
EndProjectSection
81-
EndProject
8233
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "BasicTestBaseline", "tests\BasicTestBaseline\BasicTestBaseline.csproj", "{8FDB623D-779B-4A84-BC6B-75106E41D8A4}"
8334
EndProject
8435
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TestConsole", "toys\TestConsole\TestConsole.csproj", "{651FDB97-9DE3-4BD9-9A05-827AF8F1A94A}"
8536
EndProject
86-
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Failover", "Failover", "{D082703F-1652-4C35-840D-7D377F6B9979}"
87-
ProjectSection(SolutionItems) = preProject
88-
tests\RedisConfigs\Failover\primary-6382.conf = tests\RedisConfigs\Failover\primary-6382.conf
89-
tests\RedisConfigs\Failover\replica-6383.conf = tests\RedisConfigs\Failover\replica-6383.conf
90-
EndProjectSection
91-
EndProject
9237
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "StackExchange.Redis.Server", "toys\StackExchange.Redis.Server\StackExchange.Redis.Server.csproj", "{8375813E-FBAF-4DA3-A2C7-E4645B39B931}"
9338
EndProject
9439
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "KestrelRedisServer", "toys\KestrelRedisServer\KestrelRedisServer.csproj", "{3DA1EEED-E9FE-43D9-B293-E000CFCCD91A}"
@@ -110,12 +55,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TestConsoleBaseline", "toys
11055
EndProject
11156
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = ".github", ".github\.github.csproj", "{8FB98E7D-DAE2-4465-BD9A-104000E0A2D4}"
11257
EndProject
113-
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Docker", "Docker", "{A9F81DA3-DA82-423E-A5DD-B11C37548E06}"
114-
ProjectSection(SolutionItems) = preProject
115-
tests\RedisConfigs\Docker\docker-entrypoint.sh = tests\RedisConfigs\Docker\docker-entrypoint.sh
116-
tests\RedisConfigs\Docker\supervisord.conf = tests\RedisConfigs\Docker\supervisord.conf
117-
EndProjectSection
118-
EndProject
11958
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ConsoleTest", "tests\ConsoleTest\ConsoleTest.csproj", "{A0F89B8B-32A3-4C28-8F1B-ADE343F16137}"
12059
EndProject
12160
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ConsoleTestBaseline", "tests\ConsoleTestBaseline\ConsoleTestBaseline.csproj", "{69A0ACF2-DF1F-4F49-B554-F732DCA938A3}"
@@ -134,6 +73,10 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "RESPite.Tests", "tests\RESP
13473
EndProject
13574
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "OpBench", "toys\OpBench\OpBench.csproj", "{43D3CD21-1E7E-4D28-B1BA-B6DAB3E19183}"
13675
EndProject
76+
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "RedisConfigs", "tests\RedisConfigs\RedisConfigs.csproj", "{CAE96C6D-145B-489B-9DC8-5CFBA4CC5076}"
77+
EndProject
78+
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "docker", "tests\RedisConfigs\.docker\docker.csproj", "{8ECDE6D4-37B0-4A54-8E21-B0BB3666378D}"
79+
EndProject
13780
Global
13881
GlobalSection(SolutionConfigurationPlatforms) = preSolution
13982
Debug|Any CPU = Debug|Any CPU
@@ -208,32 +151,36 @@ Global
208151
{43D3CD21-1E7E-4D28-B1BA-B6DAB3E19183}.Debug|Any CPU.Build.0 = Debug|Any CPU
209152
{43D3CD21-1E7E-4D28-B1BA-B6DAB3E19183}.Release|Any CPU.ActiveCfg = Release|Any CPU
210153
{43D3CD21-1E7E-4D28-B1BA-B6DAB3E19183}.Release|Any CPU.Build.0 = Release|Any CPU
154+
{CAE96C6D-145B-489B-9DC8-5CFBA4CC5076}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
155+
{CAE96C6D-145B-489B-9DC8-5CFBA4CC5076}.Debug|Any CPU.Build.0 = Debug|Any CPU
156+
{CAE96C6D-145B-489B-9DC8-5CFBA4CC5076}.Release|Any CPU.ActiveCfg = Release|Any CPU
157+
{CAE96C6D-145B-489B-9DC8-5CFBA4CC5076}.Release|Any CPU.Build.0 = Release|Any CPU
158+
{8ECDE6D4-37B0-4A54-8E21-B0BB3666378D}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
159+
{8ECDE6D4-37B0-4A54-8E21-B0BB3666378D}.Debug|Any CPU.Build.0 = Debug|Any CPU
160+
{8ECDE6D4-37B0-4A54-8E21-B0BB3666378D}.Release|Any CPU.ActiveCfg = Release|Any CPU
161+
{8ECDE6D4-37B0-4A54-8E21-B0BB3666378D}.Release|Any CPU.Build.0 = Release|Any CPU
211162
EndGlobalSection
212163
GlobalSection(SolutionProperties) = preSolution
213164
HideSolutionNode = FALSE
214165
EndGlobalSection
215166
GlobalSection(NestedProjects) = preSolution
216-
{96E891CD-2ED7-4293-A7AB-4C6F5D8D2B05} = {73A5C363-CA1F-44C4-9A9B-EF791A76BA6A}
217167
{EF84877F-59BE-41BE-9013-E765AF0BB72E} = {00CA0876-DA9F-44E8-B0DC-A88716BF347A}
218168
{3B8BD8F1-8BFC-4D8C-B4DA-25FFAF3D1DBE} = {73A5C363-CA1F-44C4-9A9B-EF791A76BA6A}
219169
{939FA5F7-16AA-4847-812B-6EBC3748A86D} = {73A5C363-CA1F-44C4-9A9B-EF791A76BA6A}
220-
{36255A0A-89EC-43C8-A642-F4C1ACAEF5BC} = {96E891CD-2ED7-4293-A7AB-4C6F5D8D2B05}
221-
{A3B4B972-5BD2-4D90-981F-7E51E350E628} = {96E891CD-2ED7-4293-A7AB-4C6F5D8D2B05}
222-
{38BDEEED-7BEB-4B1F-9CE0-256D63F9C502} = {96E891CD-2ED7-4293-A7AB-4C6F5D8D2B05}
223170
{8FDB623D-779B-4A84-BC6B-75106E41D8A4} = {73A5C363-CA1F-44C4-9A9B-EF791A76BA6A}
224171
{651FDB97-9DE3-4BD9-9A05-827AF8F1A94A} = {E25031D3-5C64-430D-B86F-697B66816FD8}
225-
{D082703F-1652-4C35-840D-7D377F6B9979} = {96E891CD-2ED7-4293-A7AB-4C6F5D8D2B05}
226172
{8375813E-FBAF-4DA3-A2C7-E4645B39B931} = {E25031D3-5C64-430D-B86F-697B66816FD8}
227173
{3DA1EEED-E9FE-43D9-B293-E000CFCCD91A} = {E25031D3-5C64-430D-B86F-697B66816FD8}
228174
{D58114AE-4998-4647-AFCA-9353D20495AE} = {E25031D3-5C64-430D-B86F-697B66816FD8}
229-
{A9F81DA3-DA82-423E-A5DD-B11C37548E06} = {96E891CD-2ED7-4293-A7AB-4C6F5D8D2B05}
230175
{A0F89B8B-32A3-4C28-8F1B-ADE343F16137} = {73A5C363-CA1F-44C4-9A9B-EF791A76BA6A}
231176
{69A0ACF2-DF1F-4F49-B554-F732DCA938A3} = {73A5C363-CA1F-44C4-9A9B-EF791A76BA6A}
232177
{59889284-FFEE-82E7-94CB-3B43E87DA6CF} = {73A5C363-CA1F-44C4-9A9B-EF791A76BA6A}
233178
{190742E1-FA50-4E36-A8C4-88AE87654340} = {5FA0958E-6EBD-45F4-808E-3447A293F96F}
234179
{05761CF5-CC46-43A6-814B-6BD2ECC1F0ED} = {00CA0876-DA9F-44E8-B0DC-A88716BF347A}
235180
{CA67D8CA-6CC9-40E2-8CAC-F0B1401BEF7B} = {73A5C363-CA1F-44C4-9A9B-EF791A76BA6A}
236181
{43D3CD21-1E7E-4D28-B1BA-B6DAB3E19183} = {E25031D3-5C64-430D-B86F-697B66816FD8}
182+
{CAE96C6D-145B-489B-9DC8-5CFBA4CC5076} = {73A5C363-CA1F-44C4-9A9B-EF791A76BA6A}
183+
{8ECDE6D4-37B0-4A54-8E21-B0BB3666378D} = {73A5C363-CA1F-44C4-9A9B-EF791A76BA6A}
237184
EndGlobalSection
238185
GlobalSection(ExtensibilityGlobals) = postSolution
239186
SolutionGuid = {193AA352-6748-47C1-A5FC-C9AA6B5F000B}

‎StackExchange.Redis.slnx‎

Lines changed: 2 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -34,59 +34,12 @@
3434
<Project Path="tests/BasicTestBaseline/BasicTestBaseline.csproj" />
3535
<Project Path="tests/ConsoleTest/ConsoleTest.csproj" />
3636
<Project Path="tests/ConsoleTestBaseline/ConsoleTestBaseline.csproj" />
37+
<Project Path="tests/RedisConfigs/.docker/docker.csproj" />
38+
<Project Path="tests/RedisConfigs/RedisConfigs.csproj" />
3739
<Project Path="tests/RESPite.Tests/RESPite.Tests.csproj" />
3840
<Project Path="tests/StackExchange.Redis.Benchmarks/StackExchange.Redis.Benchmarks.csproj" />
3941
<Project Path="tests/StackExchange.Redis.Tests/StackExchange.Redis.Tests.csproj" />
4042
</Folder>
41-
<Folder Name="/tests/RedisConfigs/">
42-
<File Path="tests/RedisConfigs/cli-master.cmd" />
43-
<File Path="tests/RedisConfigs/cli-secure.cmd" />
44-
<File Path="tests/RedisConfigs/cli-slave.cmd" />
45-
<File Path="tests/RedisConfigs/docker-compose.yml" />
46-
<File Path="tests/RedisConfigs/Dockerfile" />
47-
<File Path="tests/RedisConfigs/start-all.cmd" />
48-
<File Path="tests/RedisConfigs/start-all.sh" />
49-
<File Path="tests/RedisConfigs/start-basic.cmd" />
50-
<File Path="tests/RedisConfigs/start-basic.sh" />
51-
<File Path="tests/RedisConfigs/start-cluster.cmd" />
52-
<File Path="tests/RedisConfigs/start-sentinel.cmd" />
53-
<File Path="tests/RedisConfigs/wsl2.md" />
54-
</Folder>
55-
<Folder Name="/tests/RedisConfigs/Basic/">
56-
<File Path="tests/RedisConfigs/Basic/primary-6379.conf" />
57-
<File Path="tests/RedisConfigs/Basic/replica-6380.conf" />
58-
<File Path="tests/RedisConfigs/Basic/secure-6381.conf" />
59-
<File Path="tests/RedisConfigs/Basic/tls-ciphers-6384.conf" />
60-
</Folder>
61-
<Folder Name="/tests/RedisConfigs/Cluster/">
62-
<File Path="tests/RedisConfigs/Cluster/cluster-7000.conf" />
63-
<File Path="tests/RedisConfigs/Cluster/cluster-7001.conf" />
64-
<File Path="tests/RedisConfigs/Cluster/cluster-7002.conf" />
65-
<File Path="tests/RedisConfigs/Cluster/cluster-7003.conf" />
66-
<File Path="tests/RedisConfigs/Cluster/cluster-7004.conf" />
67-
<File Path="tests/RedisConfigs/Cluster/cluster-7005.conf" />
68-
<File Path="tests/RedisConfigs/Cluster/nodes-7000.conf" />
69-
<File Path="tests/RedisConfigs/Cluster/nodes-7001.conf" />
70-
<File Path="tests/RedisConfigs/Cluster/nodes-7002.conf" />
71-
<File Path="tests/RedisConfigs/Cluster/nodes-7003.conf" />
72-
<File Path="tests/RedisConfigs/Cluster/nodes-7004.conf" />
73-
<File Path="tests/RedisConfigs/Cluster/nodes-7005.conf" />
74-
</Folder>
75-
<Folder Name="/tests/RedisConfigs/Docker/">
76-
<File Path="tests/RedisConfigs/Docker/docker-entrypoint.sh" />
77-
<File Path="tests/RedisConfigs/Docker/supervisord.conf" />
78-
</Folder>
79-
<Folder Name="/tests/RedisConfigs/Failover/">
80-
<File Path="tests/RedisConfigs/Failover/primary-6382.conf" />
81-
<File Path="tests/RedisConfigs/Failover/replica-6383.conf" />
82-
</Folder>
83-
<Folder Name="/tests/RedisConfigs/Sentinel/">
84-
<File Path="tests/RedisConfigs/Sentinel/redis-7010.conf" />
85-
<File Path="tests/RedisConfigs/Sentinel/redis-7011.conf" />
86-
<File Path="tests/RedisConfigs/Sentinel/sentinel-26379.conf" />
87-
<File Path="tests/RedisConfigs/Sentinel/sentinel-26380.conf" />
88-
<File Path="tests/RedisConfigs/Sentinel/sentinel-26381.conf" />
89-
</Folder>
9043
<Folder Name="/toys/">
9144
<Project Path="toys/KestrelRedisServer/KestrelRedisServer.csproj" />
9245
<Project Path="toys/OpBench/OpBench.csproj" />

‎docs/ReleaseNotes.md‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ Current package versions:
88

99
## Unreleased
1010

11+
- Remove `[Experimental]` 8.8 `GCRA` feature ([#3074 by @mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/3074))
1112
- Detect server-mode correctly on Valkey 8+ instances ([#3050 by @wipiano](https://github.com/StackExchange/StackExchange.Redis/pull/3050))
1213
- Add Redis 8.8 stream negative acknowledgements (`XNACK`) ([#3058 by @mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/3058))
13-
- Update experimental `GCRA` APIs and wire protocol terminology from "requests" to "tokens", to match server change ([#3051 by @mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/3051))
1414
- Add experimental `Aggregate.Count` support for sorted-set combination operations against Redis 8.8 ([#3059 by @mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/3059))
1515
- Support sub-key (hash field) notifications ([#3062 by @mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/3062))
1616
- Add `ValueCondition` overloads for `SortedSetIncrement`/`SortedSetIncrementAsync`, supporting `ZADD INCR` with existence conditions ([#3071 by @mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/3071))
@@ -22,7 +22,8 @@ Current package versions:
2222

2323
## 2.12.8
2424

25-
- Add [`GCRA`](https://en.wikipedia.org/wiki/Generic_cell_rate_algorithm) support (and remove experimental flag on `VSIM`) ([#3041 by @mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/3041))
25+
- (this release also includes experimental 8.8 `GCRA` support; this feature is not being shipped yet, and it is being removed from later releases)
26+
- Remove experimental flag on `VSIM` ([#3041 by @mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/3041))
2627
- Add `IServer.GetProductVariant` to detect the product variant and version of the connected server, and use that internally
2728
to enable multi-DB operations on Valkey clusters ([#3040 by @mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/3040))
2829
- Ignore cluster nodes with the `handshake` flag ([#3043 by @TimLovellSmith](https://github.com/StackExchange/StackExchange.Redis/pull/3043))

‎docs/exp/SER006.md‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@ Redis 8.8 is currently in preview and may be subject to change.
22

33
New features in Redis 8.8:
44

5-
- `GCRA` for rate-limiting
5+
- `XNACK` for stream negative acknowledgements
6+
- `Aggregate.Count` for sorted-set combination operations
7+
- Sub-key notifications
68

7-
The corresponding library feature must also be considered subject to change:
9+
The corresponding library features must also be considered subject to change:
810

911
1. Existing bindings may cease working correctly if the underlying server API changes.
1012
2. Changes to the server API may require changes to the library API, manifesting in either/both of build-time

‎src/StackExchange.Redis/Enums/RedisCommand.cs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ internal enum RedisCommand
6060
GEOSEARCH,
6161
GEOSEARCHSTORE,
6262

63-
GCRA,
6463
GET,
6564
GETBIT,
6665
GETDEL,
@@ -325,7 +324,6 @@ internal static bool IsPrimaryOnly(this RedisCommand command)
325324
case RedisCommand.EXPIREAT:
326325
case RedisCommand.FLUSHALL:
327326
case RedisCommand.FLUSHDB:
328-
case RedisCommand.GCRA:
329327
case RedisCommand.GEOSEARCHSTORE:
330328
case RedisCommand.GETDEL:
331329
case RedisCommand.GETEX:

0 commit comments

Comments
 (0)