we don't actually need a default CycleBufferPool<T> impl;

Author: mgravell

src/RESPite/Buffers/CycleBuffer.cs

@@ -37,7 +37,7 @@ public static CycleBuffer Create(
 
     private CycleBuffer(MemoryPool<byte>? pool, ICycleBufferCallback? callback = null)
     {
-        _pool = pool ?? CycleBufferPool<byte>.Default;
+        _pool = pool ?? MemoryPool<byte>.Shared;
         _callback = callback;
         leasedStart = -1;
     }

src/RESPite/Buffers/CycleBufferPool.cs

@@ -56,32 +56,6 @@ public abstract class CycleBufferPool<T> : MemoryPool<T>
     /// <summary>
     /// Create a buffer with knowledge of the existing leased data.
     /// </summary>
-    public abstract IMemoryOwner<T> Rent(in ReadOnlySequence<T> existing);
-
-    // new MemoryPool(...) would be a non-growing buffer pool.
-    public static CycleBufferPool<T> Default { get; } = new DefaultPool();
-
-    private class DefaultPool : CycleBufferPool<T>
-    {
-        private static readonly MemoryPool<T> Tail =
-#if TRACK_MEMORY
-            MemoryTrackedPool<T>.Shared;
-#else
-            MemoryPool<T>.Shared;
-#endif
-
-        // ReSharper disable once StaticMemberInGenericType - intentional to memoize, but can vary per T
-        private static readonly int MaxSize = Tail.MaxBufferSize;
-
-        protected override void Dispose(bool disposing) { }
-
-        /// <inheritdoc/>
-        public override IMemoryOwner<T> Rent(int minBufferSize = -1) => Tail.Rent(minBufferSize);
-
-        public override int MaxBufferSize => Tail.MaxBufferSize;
-
-        /// <inheritdoc/>
-        public override IMemoryOwner<T> Rent(in ReadOnlySequence<T> existing)
-            => Tail.Rent(Math.Min(MemoryPoolExtensions.NextSize(existing), MaxSize));
-    }
+    public virtual IMemoryOwner<T> Rent(in ReadOnlySequence<T> existing)
+        => Rent(Math.Min(MemoryPoolExtensions.NextSize(existing), MaxBufferSize));
 }

src/RESPite/PublicAPI/PublicAPI.Unshipped.txt

@@ -4,9 +4,8 @@
 [SER004]static RESPite.AsciiHash.EqualsCI(System.ReadOnlySpan<char> first, System.ReadOnlySpan<byte> second) -> bool
 [SER004]static RESPite.AsciiHash.SequenceEqualsCI(System.ReadOnlySpan<byte> first, System.ReadOnlySpan<char> second) -> bool
 [SER004]static RESPite.AsciiHash.SequenceEqualsCI(System.ReadOnlySpan<char> first, System.ReadOnlySpan<byte> second) -> bool
-[SER004]abstract RESPite.Buffers.CycleBufferPool<T>.Rent(in System.Buffers.ReadOnlySequence<T> existing) -> System.Buffers.IMemoryOwner<T>!
+[SER004]virtual RESPite.Buffers.CycleBufferPool<T>.Rent(in System.Buffers.ReadOnlySequence<T> existing) -> System.Buffers.IMemoryOwner<T>!
 [SER004]RESPite.Buffers.CycleBuffer.Pool.get -> System.Buffers.MemoryPool<byte>!
 [SER004]RESPite.Buffers.CycleBufferPool<T>
 [SER004]RESPite.Buffers.CycleBufferPool<T>.CycleBufferPool() -> void
 [SER004]static RESPite.Buffers.CycleBuffer.Create(System.Buffers.MemoryPool<byte>? pool = null, RESPite.Buffers.ICycleBufferCallback? callback = null) -> RESPite.Buffers.CycleBuffer
-[SER004]static RESPite.Buffers.CycleBufferPool<T>.Default.get -> RESPite.Buffers.CycleBufferPool<T>!

src/StackExchange.Redis/ConfigurationOptions.cs

@@ -1421,7 +1421,7 @@ internal static bool TryParseRedisProtocol(string? value, out RedisProtocol prot
         }
 
         /// <summary>
-        /// The buffer pool to use when buffering responses, and for allocating <see cref="Lease{byte}"/> results.
+        /// The buffer pool to use when buffering responses, and for allocating <see cref="Lease{Byte}"/> results.
         /// </summary>
         public MemoryPool<byte>? ResponseBufferPool { get; set; }
 

tests/StackExchange.Redis.Tests/ConfigTests.cs

@@ -90,8 +90,8 @@ orderby name
                 "password",
                 "proxy",
                 "reconnectRetryPolicy",
-                "RequestCycleBufferPool",
-                "ResponseCycleBufferPool",
+                "RequestBufferPool",
+                "ResponseBufferPool",
                 "responseTimeout",
                 "ServiceName",
                 "SocketManager",