more removals

Author: mgravell

src/StackExchange.Redis/ResultProcessor.Lease.cs

@@ -63,26 +63,8 @@ protected override bool SetResultCore(PhysicalConnection connection, Message mes
     // especially useful for VLINKS
     private abstract class FlattenedLeaseProcessor<T> : ResultProcessor<Lease<T>?>
     {
-        protected virtual long GetArrayLength(in RawResult array) => array.GetItems().Length;
-
         protected virtual long GetArrayLength(in RespReader reader) => reader.AggregateLength();
 
-        protected virtual bool TryReadOne(ref Sequence<RawResult>.Enumerator reader, out T value)
-        {
-            if (reader.MoveNext())
-            {
-                return TryReadOne(in reader.Current, out value);
-            }
-            value = default!;
-            return false;
-        }
-
-        protected virtual bool TryReadOne(in RawResult result, out T value)
-        {
-            value = default!;
-            return false;
-        }
-
         protected virtual bool TryReadOne(ref RespReader reader, out T value)
         {
             value = default!;
@@ -159,56 +141,6 @@ protected override bool SetResultCore(PhysicalConnection connection, Message mes
                 throw;
             }
         }
-
-        protected override bool SetResultCore(PhysicalConnection connection, Message message, RawResult result)
-        {
-            if (result.Resp2TypeArray != ResultType.Array)
-            {
-                return false; // not an array
-            }
-            if (result.IsNull)
-            {
-                SetResult(message, Lease<T>.Empty);
-                return true;
-            }
-            var items = result.GetItems();
-            long length = 0;
-            foreach (ref RawResult item in items)
-            {
-                if (item.Resp2TypeArray == ResultType.Array && !item.IsNull)
-                {
-                    length += GetArrayLength(in item);
-                }
-            }
-
-            if (length == 0)
-            {
-                SetResult(message, Lease<T>.Empty);
-                return true;
-            }
-            var lease = Lease<T>.Create(checked((int)length), clear: false);
-            int index = 0;
-            var target = lease.Span;
-            foreach (ref RawResult item in items)
-            {
-                if (item.Resp2TypeArray == ResultType.Array && !item.IsNull)
-                {
-                    var iter = item.GetItems().GetEnumerator();
-                    while (index < target.Length && TryReadOne(ref iter, out target[index]))
-                    {
-                        index++;
-                    }
-                }
-            }
-
-            if (index == length)
-            {
-                SetResult(message, lease);
-                return true;
-            }
-            lease.Dispose(); // failed to fill?
-            return false;
-        }
     }
 
     private sealed class LeaseFloat32Processor : LeaseProcessor<float>

src/StackExchange.Redis/ResultProcessor.VectorSets.cs

@@ -19,8 +19,6 @@ internal abstract partial class ResultProcessor
 
     private sealed class VectorSetLinksWithScoresProcessor : FlattenedLeaseProcessor<VectorSetLink>
     {
-        protected override long GetArrayLength(in RawResult array) => array.GetItems().Length / 2;
-
         protected override long GetArrayLength(in RespReader reader) => reader.AggregateLength() / 2;
 
         protected override bool TryReadOne(ref RespReader reader, out VectorSetLink value)
@@ -41,22 +39,6 @@ protected override bool TryReadOne(ref RespReader reader, out VectorSetLink valu
             value = new VectorSetLink(member, score);
             return true;
         }
-
-        protected override bool TryReadOne(ref Sequence<RawResult>.Enumerator reader, out VectorSetLink value)
-        {
-            if (reader.MoveNext())
-            {
-                ref readonly RawResult first = ref reader.Current;
-                if (reader.MoveNext() && reader.Current.TryGetDouble(out var score))
-                {
-                    value = new VectorSetLink(first.AsRedisValue(), score);
-                    return true;
-                }
-            }
-
-            value = default;
-            return false;
-        }
     }
 
     private sealed class VectorSetLinksProcessor : FlattenedLeaseProcessor<RedisValue>
@@ -72,12 +54,6 @@ protected override bool TryReadOne(ref RespReader reader, out RedisValue value)
             value = reader.ReadRedisValue();
             return true;
         }
-
-        protected override bool TryReadOne(in RawResult result, out RedisValue value)
-        {
-            value = result.AsRedisValue();
-            return true;
-        }
     }
 
     private sealed partial class VectorSetInfoProcessor : ResultProcessor<VectorSetInfo?>