merge the sync and async write implementations into a shared implementation that can transition from sync to async if needed

Author: mgravell

Directory.Packages.props

@@ -27,6 +27,7 @@
     <PackageVersion Include="Newtonsoft.Json" Version="13.0.4" />
     <PackageVersion Include="NSubstitute" Version="5.3.0" />
     <PackageVersion Include="StackExchange.Redis" Version="2.13.17" />
+    <PackageVersion Include="StackExchange.Redis.StrongName" Version="1.2.6" />
     <PackageVersion Include="StyleCop.Analyzers" Version="1.2.0-beta.556" />
     <PackageVersion Include="System.Collections.Immutable" Version="10.0.5" />
     <PackageVersion Include="System.Reflection.Metadata" Version="10.0.5" />

src/RESPite.Benchmark/OldCoreBenchmarkBase.cs

@@ -187,8 +187,13 @@ bool Tick()
 
     private async ValueTask<int> GetAndMeasureString(IDatabaseAsync client)
     {
+#if LEGACY_API
+        byte[]? data = (byte[]?)(await client.StringGetAsync(GetSetKey).ConfigureAwait(false));
+        return data?.Length ?? -1;
+#else
         using var lease = await client.StringGetLeaseAsync(GetSetKey).ConfigureAwait(false);
         return lease?.Length ?? -1;
+#endif
     }
 
     [DisplayName("SET")]
@@ -228,7 +233,14 @@ private ValueTask<bool> ZAdd(IDatabaseAsync client) =>
         client.SortedSetAddAsync(SortedSetKey, "element:__rand_int__", 0).AsValueTask();
 
     [DisplayName("ZPOPMIN")]
-    private ValueTask<int> ZPopMin(IDatabaseAsync client) => HasSortedSetElement(client.SortedSetPopAsync(SortedSetKey));
+    private ValueTask<int> ZPopMin(IDatabaseAsync client)
+    {
+#if LEGACY_API
+        throw new NotSupportedException();
+#else
+        return HasSortedSetElement(client.SortedSetPopAsync(SortedSetKey));
+#endif
+    }
 
     private async ValueTask<int> HasSortedSetElement(Task<SortedSetEntry?> pending)
     {
@@ -240,8 +252,14 @@ private async ValueTask<int> HasSortedSetElement(Task<SortedSetEntry?> pending)
     private ValueTask<bool> MSet(IDatabaseAsync client) => client.StringSetAsync(_pairs).AsValueTask();
 
     [DisplayName("XADD")]
-    private ValueTask<RedisValue> XAdd(IDatabaseAsync client) =>
-        client.StreamAddAsync(StreamKey, "myfield", Payload).AsValueTask();
+    private ValueTask<RedisValue> XAdd(IDatabaseAsync client)
+    {
+#if LEGACY_API
+        throw new NotSupportedException();
+#else
+        return client.StreamAddAsync(StreamKey, "myfield", Payload).AsValueTask();
+#endif
+    }
 
     [DisplayName("LRANGE_100")]
     private ValueTask<int> LRange100(IDatabaseAsync client) => CountAsync(client.ListRangeAsync(ListKey, 0, 99));

src/RESPite.Benchmark/RESPite.Benchmark.csproj

@@ -22,6 +22,13 @@
     <PackageReference Remove="Microsoft.CodeAnalysis.PublicApiAnalyzers"/>
   </ItemGroup>
 
+  <!-- v1 builds (for comparison) -->
+  <ItemGroup Condition="'$(TargetVer)'=='1'">
+    <PackageReference Include="StackExchange.Redis.StrongName" />
+  </ItemGroup>
+  <PropertyGroup Condition="'$(TargetVer)'=='1'">
+    <DefineConstants>$(DefineConstants);LEGACY_API</DefineConstants>
+  </PropertyGroup>
   <!-- v2 builds -->
   <ItemGroup Condition="'$(TargetVer)'=='2'">
     <PackageReference Include="StackExchange.Redis"/>