Skip to content

Commit 7b5252f

Browse files
committed
additional validation on conditional members
1 parent aa5ff5c commit 7b5252f

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

tests/StackExchange.Redis.Tests/HotKeysTests.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,20 @@ public void CanUseClusterFilter(bool sample)
5151
Assert.Equal(3, result.SampleRatio);
5252
Assert.True(result.SampledCommandsSelectedSlotsMicroseconds >= 0, nameof(result.SampledCommandsSelectedSlotsMicroseconds));
5353
Assert.True(result.NetworkBytesSampledCommandsSelectedSlotsRaw >= 0, nameof(result.NetworkBytesSampledCommandsSelectedSlotsRaw));
54+
Assert.True(result.SampledCommandsSelectedSlotsTime.HasValue);
55+
Assert.True(result.SampledCommandsSelectedSlotsNetworkBytes.HasValue);
5456
}
5557
else
5658
{
5759
Assert.Equal(1, result.SampleRatio);
5860
Assert.Equal(-1, result.SampledCommandsSelectedSlotsMicroseconds);
5961
Assert.Equal(-1, result.NetworkBytesSampledCommandsSelectedSlotsRaw);
62+
Assert.False(result.SampledCommandsSelectedSlotsTime.HasValue);
63+
Assert.False(result.SampledCommandsSelectedSlotsNetworkBytes.HasValue);
6064
}
65+
66+
Assert.True(result.AllCommandsSelectedSlotsTime.HasValue);
67+
Assert.True(result.AllCommandsSelectedSlotsNetworkBytes.HasValue);
6168
}
6269
}
6370

@@ -178,6 +185,11 @@ private void CheckSimpleWithKey(RedisKey key, HotKeysResult hotKeys, IServer ser
178185
Assert.True(hotKeys.TotalCpuTimeUserMicroseconds >= 0, nameof(hotKeys.TotalCpuTimeUserMicroseconds));
179186
Assert.True(hotKeys.AllCommandsAllSlotsNetworkBytes > 0, nameof(hotKeys.AllCommandsAllSlotsNetworkBytes));
180187
Assert.True(hotKeys.TotalNetworkBytes > 0, nameof(hotKeys.TotalNetworkBytes));
188+
189+
Assert.False(hotKeys.AllCommandsSelectedSlotsTime.HasValue);
190+
Assert.False(hotKeys.AllCommandsSelectedSlotsNetworkBytes.HasValue);
191+
Assert.False(hotKeys.SampledCommandsSelectedSlotsTime.HasValue);
192+
Assert.False(hotKeys.SampledCommandsSelectedSlotsNetworkBytes.HasValue);
181193
}
182194

183195
[Fact]

0 commit comments

Comments
 (0)