xpending unit test; switch benchmark

Author: mgravell

src/StackExchange.Redis/APITypes/LCSMatchResult.cs

@@ -137,7 +137,7 @@ public override int GetHashCode()
         /// <param name="first">The position of the matched substring in the first string.</param>
         /// <param name="second">The position of the matched substring in the second string.</param>
         /// <param name="length">The length of the match.</param>
-        internal LCSMatch(LCSPosition first, LCSPosition second, long length)
+        internal LCSMatch(in LCSPosition first, in LCSPosition second, long length)
         {
             _first = first;
             _second = second;

src/StackExchange.Redis/ResultProcessor.cs

@@ -2102,39 +2102,18 @@ protected override bool SetResultCore(PhysicalConnection connection, Message mes
                                     matchesArray = iter.Value.ReadPastArray(ref failed, static (ref failed, ref reader) =>
                                     {
                                         // Don't even bother if we've already failed
-                                        if (failed) return default;
-
-                                        if (!reader.IsAggregate)
-                                        {
-                                            failed = true;
-                                            return default;
-                                        }
-
-                                        var matchChildren = reader.AggregateChildren();
-
-                                        // First range (2-element array: [start, end])
-                                        if (!(matchChildren.MoveNext() && TryReadPosition(ref matchChildren.Value, out var firstPos)))
-                                        {
-                                            failed = true;
-                                            return default;
-                                        }
-
-                                        // Second range (2-element array: [start, end])
-                                        if (!(matchChildren.MoveNext() && TryReadPosition(ref matchChildren.Value, out var secondPos)))
-                                        {
-                                            failed = true;
-                                            return default;
-                                        }
-
-                                        // Length
-                                        if (!(matchChildren.MoveNext() && matchChildren.Value.IsScalar))
+                                        if (!failed && reader.IsAggregate)
                                         {
-                                            failed = true;
-                                            return default;
+                                            var matchChildren = reader.AggregateChildren();
+                                            if (matchChildren.MoveNext() && TryReadPosition(ref matchChildren.Value, out var firstPos)
+                                                && matchChildren.MoveNext() && TryReadPosition(ref matchChildren.Value, out var secondPos)
+                                                && matchChildren.MoveNext() && matchChildren.Value.IsScalar && matchChildren.Value.TryReadInt64(out var length))
+                                            {
+                                                return new LCSMatchResult.LCSMatch(firstPos, secondPos, length);
+                                            }
                                         }
-                                        var length = matchChildren.Value.TryReadInt64(out var matchLen) ? matchLen : 0;
-
-                                        return new LCSMatchResult.LCSMatch(firstPos, secondPos, length);
+                                        failed = true;
+                                        return default;
                                     });
 
                                     // Check if anything went wrong