Skip to content

Commit aad00c0

Browse files
committed
fix brittle ScanCancellable test
1 parent 0e23e82 commit aad00c0

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

tests/StackExchange.Redis.Tests/CancellationTests.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,8 @@ public async Task CancellationDuringOperation_Async_CancelsGracefully(CancelStra
156156
[Fact]
157157
public async Task ScanCancellable()
158158
{
159+
Skip.UnlessLongRunning(); // because of CLIENT PAUSE impact to unrelated tests
160+
159161
using var conn = Create();
160162
var db = conn.GetDatabase();
161163
var server = conn.GetServer(conn.GetEndPoints()[0]);
@@ -182,7 +184,7 @@ public async Task ScanCancellable()
182184
var taken = watch.ElapsedMilliseconds;
183185
// Expected if cancellation happens during operation
184186
Log($"Cancelled after {taken}ms");
185-
Assert.True(taken < ConnectionPauseMilliseconds / 2, "Should have cancelled much sooner");
187+
Assert.True(taken < (ConnectionPauseMilliseconds * 3) / 4, $"Should have cancelled sooner; took {taken}ms");
186188
Assert.Equal(cts.Token, oce.CancellationToken);
187189
}
188190
}

0 commit comments

Comments
 (0)