- improve "moved" test for "did the client already know the new node?"

- fix where RESP3 default is specified for the toy server

Author: mgravell

tests/StackExchange.Redis.Tests/InProcessTestServer.cs

@@ -85,6 +85,7 @@ public ConfigurationOptions GetClientConfig(bool withPubSub = true /*, WriteMode
             AsyncTimeout = 5000,
             AllowAdmin = true,
             Tunnel = Tunnel,
+            Protocol = TestContext.Current.GetProtocol(),
             // WriteMode = (BufferedStreamWriter.WriteMode)writeMode,
         };
         if (!string.IsNullOrEmpty(Password)) config.Password = Password;

tests/StackExchange.Redis.Tests/MovedUnitTests.cs

@@ -11,6 +11,7 @@ namespace StackExchange.Redis.Tests;
 /// When a MOVED error points to the same endpoint, the client should reconnect before retrying,
 /// allowing the DNS record/proxy/load balancer to route to a different underlying server host.
 /// </summary>
+[RunPerProtocol]
 public class MovedUnitTests(ITestOutputHelper log)
 {
     private RedisKey Me([CallerMemberName] string callerName = "") => callerName;
@@ -48,13 +49,16 @@ public async Task CrossSlotDisallowed(ServerType serverType)
     }
 
     [Theory]
-    [InlineData(true)]
-    [InlineData(false)]
-    public async Task KeyMigrationFollowed(bool allowFollowRedirects)
+    [InlineData(true, false)]
+    [InlineData(false, false)]
+    [InlineData(true, true)]
+    [InlineData(false, true)]
+    public async Task KeyMigrationFollowed(bool allowFollowRedirects, bool toNewUnknownNode)
     {
         RedisKey key = Me();
         using var server = new InProcessTestServer(log) { ServerType = ServerType.Cluster };
-        var secondNode = server.AddEmptyNode();
+        // depending on the test, we might not want the client to know about the second node yet
+        var secondNode = toNewUnknownNode ? null : server.AddEmptyNode();
 
         await using var muxer = await server.ConnectAsync();
         var db = muxer.GetDatabase();
@@ -63,6 +67,11 @@ public async Task KeyMigrationFollowed(bool allowFollowRedirects)
         var value = await db.StringGetAsync(key);
         Assert.Equal("value", (string?)value);
 
+        if (toNewUnknownNode) // if deferred, the client doesn't know about this yet
+        {
+            secondNode = server.AddEmptyNode();
+        }
+
         server.Migrate(key, secondNode);
 
         if (allowFollowRedirects)

tests/StackExchange.Redis.Tests/TestBase.cs

@@ -635,7 +635,6 @@ public IInternalConnectionMultiplexer CreateClient()
             {
                 var config = _server.GetClientConfig();
                 config.AllowAdmin = _allowAdmin;
-                config.Protocol = TestContext.Current.GetProtocol();
                 if (_channelPrefix is not null)
                 {
                     config.ChannelPrefix = RedisChannel.Literal(_channelPrefix);