avoid Failed nomenclature in tests - makes it hard to isolate CI problems

Author: mgravell

…dis.Tests/ConnectionFailedErrorsTests.cs …is.Tests/ConnectionFailureErrorsTests.cstests/StackExchange.Redis.Tests/ConnectionFailedErrorsTests.cs renamed to tests/StackExchange.Redis.Tests/ConnectionFailureErrorsTests.cs tests/StackExchange.Redis.Tests/ConnectionFailedErrorsTests.cs renamed to tests/StackExchange.Redis.Tests/ConnectionFailureErrorsTests.cs

@@ -7,7 +7,7 @@
 
 namespace StackExchange.Redis.Tests;
 
-public class ConnectionFailedErrorsTests(ITestOutputHelper output) : TestBase(output)
+public class ConnectionFailureErrorsTests(ITestOutputHelper output) : TestBase(output)
 {
     [Theory]
     [InlineData(true)]

tests/StackExchange.Redis.Tests/ConnectionShutdownTests.cs

@@ -9,7 +9,7 @@ public class ConnectionShutdownTests(ITestOutputHelper output) : TestBase(output
 {
     [Fact(Skip = "Unfriendly")]
     [Trait(TestCategories.Category, TestCategories.SimulatedConnectionFailure)]
-    public async Task ShutdownRaisesConnectionFailedAndRestore()
+    public async Task ShutdownRaisesConnectionFailureAndRestore()
     {
         await using var conn = Create(allowAdmin: true, allowSimulateConnectionFailure: true);
 

tests/StackExchange.Redis.Tests/GlobalSuppressions.cs

@@ -5,11 +5,11 @@
 
 using System.Diagnostics.CodeAnalysis;
 
-[assembly: SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "Pending", Scope = "member", Target = "~M:StackExchange.Redis.Tests.ConnectionFailedErrorsTests.SSLCertificateValidationError(System.Boolean)")]
+[assembly: SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "Pending", Scope = "member", Target = "~M:StackExchange.Redis.Tests.ConnectionFailureErrorsTests.SSLCertificateValidationError(System.Boolean)")]
 [assembly: SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "Pending", Scope = "member", Target = "~M:StackExchange.Redis.Tests.PubSubTests.ExplicitPublishMode")]
 [assembly: SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "Pending", Scope = "member", Target = "~M:StackExchange.Redis.Tests.SSLTests.ConnectToSSLServer(System.Boolean,System.Boolean)")]
 [assembly: SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "Pending", Scope = "member", Target = "~M:StackExchange.Redis.Tests.SSLTests.ShowCertFailures(StackExchange.Redis.Tests.Helpers.TextWriterOutputHelper)~System.Net.Security.RemoteCertificateValidationCallback")]
-[assembly: SuppressMessage("Usage", "xUnit1004:Test methods should not be skipped", Justification = "Pending", Scope = "member", Target = "~M:StackExchange.Redis.Tests.ConnectionShutdownTests.ShutdownRaisesConnectionFailedAndRestore")]
+[assembly: SuppressMessage("Usage", "xUnit1004:Test methods should not be skipped", Justification = "Pending", Scope = "member", Target = "~M:StackExchange.Redis.Tests.ConnectionShutdownTests.ShutdownRaisesConnectionFailureAndRestore")]
 [assembly: SuppressMessage("Usage", "xUnit1004:Test methods should not be skipped", Justification = "Pending", Scope = "member", Target = "~M:StackExchange.Redis.Tests.Issues.BgSaveResponseTests.ShouldntThrowException(StackExchange.Redis.SaveType)")]
 [assembly: SuppressMessage("Roslynator", "RCS1077:Optimize LINQ method call.", Justification = "Pending", Scope = "member", Target = "~M:StackExchange.Redis.Tests.SentinelTests.PrimaryConnectTest~System.Threading.Tasks.Task")]
 [assembly: SuppressMessage("Roslynator", "RCS1077:Optimize LINQ method call.", Justification = "Pending", Scope = "member", Target = "~M:StackExchange.Redis.Tests.SentinelTests.PrimaryConnectAsyncTest~System.Threading.Tasks.Task")]