move KeyIdle[Async]Tests to a server without replication

Author: mgravell

tests/StackExchange.Redis.Tests/KeyIdleAsyncTests.cs

@@ -8,6 +8,17 @@ namespace StackExchange.Redis.Tests;
 [RunPerProtocol]
 public class KeyIdleAsyncTests(ITestOutputHelper output, SharedConnectionFixture fixture) : TestBase(output, fixture)
 {
+    // Target the standalone secure server (6381) rather than the default primary (6379).
+    // OBJECT IDLETIME is reset via the value's LRU access clock, but Redis deliberately
+    // suppresses that update while a save/AOF/replication-sync child is active (copy-on-write
+    // avoidance). The default primary has a replica attached, and every replica full-sync forks
+    // such a child; if one overlaps a touch/read in these tests, the idle time isn't reset and the
+    // test flakes (observed on Windows CI). 6381 has no replica and no persistence, so no fork ever
+    // suppresses the reset and the behaviour is deterministic. Overriding GetConfiguration here also
+    // opts these tests out of the shared connection fixture, giving each a dedicated 6381 connection.
+    protected override string GetConfiguration()
+        => TestConfig.Current.SecureServerAndPort + ",password=" + TestConfig.Current.SecurePassword;
+
     [Fact]
     public async Task IdleTimeAsync()
     {
@@ -17,13 +28,14 @@ public async Task IdleTimeAsync()
         var db = conn.GetDatabase();
         db.KeyDelete(key, CommandFlags.FireAndForget);
         db.StringSet(key, "new value", flags: CommandFlags.FireAndForget);
+        var timer = Stopwatch.StartNew();
         await Task.Delay(2000).ForAwait();
         var idleTime = await db.KeyIdleTimeAsync(key).ForAwait();
-        Assert.True(idleTime > TimeSpan.Zero, "First check");
+        Assert.True(idleTime > TimeSpan.Zero, $"First check: {idleTime} should be > 0; elapsed: {timer.ElapsedMilliseconds}ms");
 
         db.StringSet(key, "new value2", flags: CommandFlags.FireAndForget);
         var idleTime2 = await db.KeyIdleTimeAsync(key).ForAwait();
-        Assert.True(idleTime2 < idleTime, "Second check");
+        Assert.True(idleTime2 < idleTime, $"Second check: {idleTime2} should be < {idleTime}; elapsed: {timer.ElapsedMilliseconds}ms");
 
         db.KeyDelete(key);
         var idleTime3 = await db.KeyIdleTimeAsync(key).ForAwait();

tests/StackExchange.Redis.Tests/KeyIdleTests.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Diagnostics;
 using System.Threading.Tasks;
 using Xunit;
 
@@ -7,6 +8,17 @@ namespace StackExchange.Redis.Tests;
 [RunPerProtocol]
 public class KeyIdleTests(ITestOutputHelper output, SharedConnectionFixture fixture) : TestBase(output, fixture)
 {
+    // Target the standalone secure server (6381) rather than the default primary (6379).
+    // OBJECT IDLETIME is reset via the value's LRU access clock, but Redis deliberately
+    // suppresses that update while a save/AOF/replication-sync child is active (copy-on-write
+    // avoidance). The default primary has a replica attached, and every replica full-sync forks
+    // such a child; if one overlaps a touch/read in these tests, the idle time isn't reset and the
+    // test flakes (observed on Windows CI). 6381 has no replica and no persistence, so no fork ever
+    // suppresses the reset and the behaviour is deterministic. Overriding GetConfiguration here also
+    // opts these tests out of the shared connection fixture, giving each a dedicated 6381 connection.
+    protected override string GetConfiguration()
+        => TestConfig.Current.SecureServerAndPort + ",password=" + TestConfig.Current.SecurePassword;
+
     [Fact]
     public async Task IdleTime()
     {
@@ -16,13 +28,14 @@ public async Task IdleTime()
         var db = conn.GetDatabase();
         db.KeyDelete(key, CommandFlags.FireAndForget);
         db.StringSet(key, "new value", flags: CommandFlags.FireAndForget);
+        var timer = Stopwatch.StartNew();
         await Task.Delay(2000).ForAwait();
         var idleTime = db.KeyIdleTime(key);
-        Assert.True(idleTime > TimeSpan.Zero);
+        Assert.True(idleTime > TimeSpan.Zero, $"First check: {idleTime} should be > 0; elapsed: {timer.ElapsedMilliseconds}ms");
 
         db.StringSet(key, "new value2", flags: CommandFlags.FireAndForget);
         var idleTime2 = db.KeyIdleTime(key);
-        Assert.True(idleTime2 < idleTime);
+        Assert.True(idleTime2 < idleTime, $"Second check: {idleTime2} should be < {idleTime}; elapsed: {timer.ElapsedMilliseconds}ms");
 
         db.KeyDelete(key);
         var idleTime3 = db.KeyIdleTime(key);
@@ -38,12 +51,13 @@ public async Task TouchIdleTime()
         var db = conn.GetDatabase();
         db.KeyDelete(key, CommandFlags.FireAndForget);
         db.StringSet(key, "new value", flags: CommandFlags.FireAndForget);
+        var timer = Stopwatch.StartNew();
         await Task.Delay(2000).ForAwait();
         var idleTime = db.KeyIdleTime(key);
-        Assert.True(idleTime > TimeSpan.Zero, "First check");
+        Assert.True(idleTime > TimeSpan.Zero, $"First check: {idleTime} should be > 0; elapsed: {timer.ElapsedMilliseconds}ms");
 
-        Assert.True(db.KeyTouch(key), "Second check");
+        Assert.True(db.KeyTouch(key), $"Second check: should be True; elapsed: {timer.ElapsedMilliseconds}ms");
         var idleTime1 = db.KeyIdleTime(key);
-        Assert.True(idleTime1 < idleTime, "Third check");
+        Assert.True(idleTime1 < idleTime, $"Third check: {idleTime1} should be < {idleTime}; elapsed: {timer.ElapsedMilliseconds}ms");
     }
 }